Add "reporter" and "assignee" fields in subscription filters #890

shigalovalexs · 2022-11-17T03:27:54Z

Summary:
Added "reporter" and "assignee" fields to subscriptions modal to filter notifications in channels by users
Also added a field "reporter" to the issue create dialog if the project supports it

Ticket Link

Fixes #891

* bump version 3.2.1 * MM-47046/MM-47052 Use version of React DOM provided by web app (#868) * add ReactDOM to webpack externals * npm install --verbose * use git insteadOf * Fix linter issues (#878) * remove git config change Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>

mattermod · 2022-11-17T03:27:58Z

Hello @shigalovalexs,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

mickmister

Thanks for this @shigalovalexs! LGTM 👍 just one suggestion to remove the GitHub actions added in this PR. cc @hanzei for discussion on this

.github/workflows/build-plugin-jira.yml

mattermod · 2022-11-29T01:02:19Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

javaguirre · 2022-11-29T15:12:10Z

webapp/src/utils/jira_issue_metadata.tsx

@@ -264,6 +276,10 @@ export function isLabelField(field: JiraField | FilterField): boolean {
    return field.schema.system === 'labels' || field.schema.custom === 'com.atlassian.jira.plugin.system.customfieldtypes:labels';
 }

+export function isUserField(field: JiraField | FilterField): boolean {
+    return field.schema.type === 'user' || field.schema.custom === 'com.atlassian.jira.plugin.system.customfieldtypes:userpicker';


Could the string 'com.atlassian.....' be a constant more to the top of the file? It seems some kind of "magic string".

javaguirre · 2022-11-29T15:14:59Z

webapp/src/utils/jira_issue_metadata.tsx

@@ -179,7 +179,7 @@ function isValidFieldForFilter(field: JiraField): boolean {
    }

    return allowedTypes.includes(type) || (custom && acceptedCustomTypesForFilters.includes(custom)) ||


I find this part a bit difficult to follow and understand, but this would be a future refactor.

also allowedTypes is a bit confusing, because we have here other types (option, user) but those aren't in the allowedTypes array, but they're called types too 🤷 .

But as I said, this is for the future.

@javaguirre Yeah I too think option and user should be added to allowedTypes. I don't see any logic that would break if we did that

mattermod · 2022-12-12T01:02:15Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei · 2023-02-21T09:33:40Z

/update-branch

hanzei · 2023-02-21T09:34:26Z

@shigalovalexs Is the target branch here really correct?

hanzei · 2023-02-22T07:02:16Z

@shigalovalexs Are you open to signing the CLA?

shigalovalexs · 2023-02-22T12:19:26Z

@hanzei Hi, yes, I`m agree to sign the CLA

hanzei · 2023-02-28T15:28:51Z

@shigalovalexs Could you please sign the form at https://mattermost.com/mattermost-contributor-agreement/?

hanzei · 2023-02-28T15:40:22Z

Secondly, the PR should target master. I've changed the target branch. You need to rebase on master. Sorry for the inconvenience.

hanzei · 2023-03-03T12:52:58Z

plugin.json

    "icon_path": "assets/icon.svg",
-    "version": "3.2.0",
+    "version": "3.2.1",


Unrelated change?

This is not resolved

server/manifest.go

mattermost-build · 2023-03-14T01:01:43Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei · 2023-03-30T09:25:57Z

/update-branch

mickmister and others added 7 commits October 31, 2022 08:02

Added support for "reporter" and "assignee" field

3db15e2

fix workflow

2760aef

add reporter field to create issue modal

11da293

Add reporter field to create issue modal

84e36ed

fix error in issue.go

dbda93f

subscriptions/channel

8e0f2aa

shigalovalexs requested a review from mickmister as a code owner November 17, 2022 03:27

mattermod added the Contributor label Nov 17, 2022

Update channel_subscription_filter.tsx

189c5e6

mickmister linked an issue Nov 17, 2022 that may be closed by this pull request

Add "reporter" and "assignee" fields in subscription filters #891

Open

mickmister reviewed Nov 17, 2022

View reviewed changes

.github/workflows/build-plugin-jira.yml Outdated Show resolved Hide resolved

Delete build-plugin-jira.yml

f1fe428

mattermod added the Lifecycle/1:stale label Nov 29, 2022

hanzei requested a review from mickmister November 29, 2022 14:09

hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Lifecycle/1:stale labels Nov 29, 2022

hanzei requested a review from javaguirre November 29, 2022 14:09

javaguirre suggested changes Nov 29, 2022

View reviewed changes

mickmister approved these changes Dec 1, 2022

View reviewed changes

mattermod added the Lifecycle/1:stale label Dec 12, 2022

mickmister requested a review from DHaussermann February 16, 2023 21:07

Merge branch 'release-3.2.1' into release-3.2.1-custom

f21ec64

hanzei removed the Lifecycle/1:stale label Feb 21, 2023

hanzei requested review from trilopin and srkgupta and removed request for trilopin, srkgupta and DHaussermann February 21, 2023 09:35

hanzei added the Awaiting Submitter Action Blocked on the author label Feb 22, 2023

hanzei changed the base branch from release-3.2.1 to master February 28, 2023 15:29

Merge branch 'master' into release-3.2.1-custom

d9aaba5

hanzei reviewed Mar 3, 2023

View reviewed changes

mattermost-build added the Lifecycle/1:stale label Mar 14, 2023

Merge branch 'master' into release-3.2.1-custom

9735700

hanzei added Work In Progress Not yet ready for review and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 21, 2023

hanzei added Lifecycle/2:inactive and removed Lifecycle/1:stale labels Sep 1, 2023

shigalovalexs closed this by deleting the head repository Mar 26, 2024

mattermost-build removed Awaiting Submitter Action Blocked on the author Work In Progress Not yet ready for review labels Mar 26, 2024

Kshitij-Katiyar mentioned this pull request Aug 2, 2024

[MM-891]: Added reporter and assignee fields in subscription filters #1112

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "reporter" and "assignee" fields in subscription filters #890

Add "reporter" and "assignee" fields in subscription filters #890

shigalovalexs commented Nov 17, 2022 •

edited by mickmister

Loading

mattermod commented Nov 17, 2022

mickmister left a comment

mattermod commented Nov 29, 2022

javaguirre Nov 29, 2022

javaguirre Nov 29, 2022

javaguirre Nov 29, 2022

mickmister Dec 1, 2022 •

edited

Loading

mattermod commented Dec 12, 2022

hanzei commented Feb 21, 2023

hanzei commented Feb 21, 2023

hanzei commented Feb 22, 2023

shigalovalexs commented Feb 22, 2023

hanzei commented Feb 28, 2023

hanzei commented Feb 28, 2023

hanzei Mar 3, 2023

hanzei Mar 30, 2023

mattermost-build commented Mar 14, 2023

hanzei commented Mar 30, 2023

		@@ -179,7 +179,7 @@ function isValidFieldForFilter(field: JiraField): boolean {
		}

		return allowedTypes.includes(type) \|\| (custom && acceptedCustomTypesForFilters.includes(custom)) \|\|

Add "reporter" and "assignee" fields in subscription filters #890

Add "reporter" and "assignee" fields in subscription filters #890

Conversation

shigalovalexs commented Nov 17, 2022 • edited by mickmister Loading

Ticket Link

mattermod commented Nov 17, 2022

mickmister left a comment

Choose a reason for hiding this comment

mattermod commented Nov 29, 2022

javaguirre Nov 29, 2022

Choose a reason for hiding this comment

javaguirre Nov 29, 2022

Choose a reason for hiding this comment

javaguirre Nov 29, 2022

Choose a reason for hiding this comment

mickmister Dec 1, 2022 • edited Loading

Choose a reason for hiding this comment

mattermod commented Dec 12, 2022

hanzei commented Feb 21, 2023

hanzei commented Feb 21, 2023

hanzei commented Feb 22, 2023

shigalovalexs commented Feb 22, 2023

hanzei commented Feb 28, 2023

hanzei commented Feb 28, 2023

hanzei Mar 3, 2023

Choose a reason for hiding this comment

hanzei Mar 30, 2023

Choose a reason for hiding this comment

mattermost-build commented Mar 14, 2023

hanzei commented Mar 30, 2023

shigalovalexs commented Nov 17, 2022 •

edited by mickmister

Loading

mickmister Dec 1, 2022 •

edited

Loading