Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more JS syntax errors #38956

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Fix more JS syntax errors #38956

merged 2 commits into from
Apr 7, 2025

Conversation

Josh-Cena
Copy link
Member

Continuation of #38941 and #38943

@Josh-Cena Josh-Cena requested review from a team as code owners April 3, 2025 18:10
@Josh-Cena Josh-Cena requested review from chrisdavidmills, sideshowbarker and willdurand and removed request for a team April 3, 2025 18:10
@github-actions github-actions bot added Content:WebExt WebExtensions docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Learn Learning area docs labels Apr 3, 2025
@Josh-Cena Josh-Cena requested review from bsmth and removed request for a team, chrisdavidmills, sideshowbarker and willdurand April 3, 2025 18:10
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Apr 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025 •
edited
Loading

Preview URLs (45 pages)
Flaws (7)

Note! 40 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/ShadowRoot
Title: ShadowRoot
Flaw count: 1

  • macros:
    • Can't resolve /en-US/docs/Web/API/ShadowRoot/getSelection

URL: /en-US/docs/Web/API/Web_Audio_API/Simple_synth
Title: Example and tutorial: Simple synth keyboard
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/API/Web_Audio_API/Tools which is a redirect

URL: /en-US/docs/Web/API/Web_Audio_API/Using_AudioWorklet
Title: Background audio processing using AudioWorklet
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/API/Web_Audio_API/Tools which is a redirect

URL: /en-US/docs/Web/API/Web_components/Using_custom_elements
Title: Using custom elements
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/Web_Components/Using_custom_elements which is a redirect
    • Macro produces link /en-US/docs/Web/Web_Components/Using_shadow_DOM which is a redirect
    • Macro produces link /en-US/docs/Web/Web_Components/Using_templates_and_slots which is a redirect

URL: /en-US/docs/Web/HTTP/Guides/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_PAC_file
Title: Proxy Auto-Configuration (PAC) file
Flaw count: 1

  • unknown:
    • No generic content config found

(comment last updated: 2025-04-03 19:41:06)

@Josh-Cena Josh-Cena requested a review from a team as a code owner April 3, 2025 19:13
@github-actions github-actions bot added Content:HTTP HTTP docs Content:wasm WebAssembly docs size/xl [PR only] >1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Apr 3, 2025
rebloor
rebloor approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay for the web extension related change

bsmth
bsmth reviewed Apr 7, 2025
View reviewed changes
files/en-us/learn_web_development/extensions/testing/your_own_automation_environment/index.md
@@ -569,7 +569,7 @@ Let's update our `bstack_duck_test.js` demo, to show how these features work:

1. Install the [axios](https://www.npmjs.com/package/axios) module by running the following command inside your project directory:

```js
```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one :)

bsmth
bsmth approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bsmth bsmth merged commit 3c13d9a into mdn:main Apr 7, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the fix-syntax branch April 7, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rebloor rebloor rebloor approved these changes

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:HTTP HTTP docs Content:JS JavaScript docs Content:Learn Learning area docs Content:wasm WebAssembly docs Content:WebAPI Web API docs Content:WebExt WebExtensions docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Josh-Cena @rebloor @bsmth