typo fix in example code for sizes attribute #40948
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the example code based on below explanation (If the viewport is 600px wide or less, the slot size is 400px; otherwise, it is 800px.)
github-actions
bot
added
Content:HTML
estelle
reviewed
Sep 1, 2025
| @@ -118,7 +118,7 @@ For example: | |||
| <picture> | |||
| <source | |||
| srcset="small.jpg 480w, medium.jpg 800w, large.jpg 1200w" | |||
| sizes="(max-width: 600px) 400px, 600px" | |||
| sizes="(max-width: 600px) 400px, 800px" | |||
There was a problem hiding this comment.
Thanks for catching and ediing the typo.
I think we should change line 129 instead. We wouldn't want an 800px wide img in a viewport that is less than 600px wide.
There was a problem hiding this comment.
I think sizes="(max-width: 600px) 400px, 800px" tells if width <= 600px choose 400px and otherwise width > 600px choose 800px no?
Since we already have a value for 800w in srcset, changing 600px to 800px seems more easy to me
|
Preview URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the example code based on below explanation (If the viewport is 600px wide or less, the slot size is 400px; otherwise, it is 800px.)
Motivation
Additional details
Related issues and pull requests