Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust logging and outputs for all exceptions #1226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrjoshuap
Copy link

This is a change to ensure that logging is configured in a sane fashion. I reworked the configuration so that it will honor LOGLEVEL except when DEBUG is enabled. Arguments maybe on the best implementation, but I'm running in Kubernetes and want to see warnings+ only.

Description

Found all exception catches, they now print warnings. Could argue some might be better as debug/info. Found missing import logging and added appropriate logger = setup.

Steps

With DEBUG=False

  1. Run MediaCMS, set DEBUG=False and LOGLEVEL to [DEBUG|INFO|WARN|ERROR]

  2. Outputs ONLY to console, no files, LOGLEVEL and up.

  3. Logs should properly be logged, filtered and things will be more obvious.

  4. Run MediaCMS, set DEBUG=True and LOGLEVEL is ignored

  5. Outputs to console AND error_files

  6. Logs should be properly logged, filtered and things will be way more verbose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant