More robust logging and outputs for all exceptions #1226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change to ensure that logging is configured in a sane fashion. I reworked the configuration so that it will honor LOGLEVEL except when DEBUG is enabled. Arguments maybe on the best implementation, but I'm running in Kubernetes and want to see warnings+ only.
Description
Found all exception catches, they now print warnings. Could argue some might be better as debug/info. Found missing
import logging
and added appropriatelogger =
setup.Steps
With
DEBUG=False
Run MediaCMS, set
DEBUG=False
andLOGLEVEL
to[DEBUG|INFO|WARN|ERROR]
Outputs ONLY to console, no files,
LOGLEVEL
and up.Logs should properly be logged, filtered and things will be more obvious.
Run MediaCMS, set
DEBUG=True
andLOGLEVEL
is ignoredOutputs to console AND error_files
Logs should be properly logged, filtered and things will be way more verbose