Improve HttpRequests
#1741
Improve HttpRequests
#1741
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
+ Coverage 98.95% 99.36% +0.40%
==========================================
Files 16 16
Lines 1537 1566 +29
Branches 332 343 +11
==========================================
+ Hits 1521 1556 +35
+ Misses 16 10 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
flevi29
added
maintenance
src/clients/client.ts
Outdated
| body: params, | ||
| })) as EnqueuedTaskObject; | ||
|
|
||
| return new EnqueuedTask(taks); | ||
| } |
There was a problem hiding this comment.
bug: previously this did not return EnqueuedTask, but rather EnqueuedTaskObject
tests/client.test.ts
Outdated
| test(`${permission} key: Create client with custom headers (object)`, async () => { | ||
| const key = await getKey(permission); | ||
| const client = new MeiliSearch({ | ||
| ...config, | ||
| apiKey: key, | ||
| requestInit: { | ||
| headers: { | ||
| "Hello-There!": "General Kenobi", | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| assert.isTrue(await client.isHealthy()); | ||
|
|
||
| assert.isDefined(fetchSpy.mock.lastCall); | ||
| const [, requestInit] = fetchSpy.mock.lastCall!; | ||
|
|
||
| assert.isDefined(requestInit?.headers); | ||
| assert.instanceOf(requestInit!.headers, Headers); | ||
| assert.strictEqual( | ||
| (requestInit!.headers! as Headers).get("Hello-There!"), | ||
| "General Kenobi", | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Because headers are internal implementation details, to check them we have to spy on fetch now.
|
Alright, no problem, I just didn't know you guys talked before releasing. But to be fair I'm also excited to get my PRs merged 😅. |
|
Once v1.13 is out, merging your PR will be the priority @flevi29 😉 |
|
All good for me @flevi29. If you can fix the small conflicts, I'll get this merged. Thanks for the great work! |
|
@Strift fixed |
|
Build succeeded:
|
Pull Request
Sorry for the huge PR, but
HttpRequestsis core, and is used everywhere.What does this PR do?
EnqueuedTaskObjects not being converted toEnqueuedTaskCaution
BREAKING
Rename
Config.requestConfig->Config.requestInit,signalcan no longer be passed to it.Warning
Deprecate
Config.httpClient#1824PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!