Skip to content

Improve search #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Improve search #1925

wants to merge 12 commits into from

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Apr 18, 2025

Pull Request

Related issue

Fixes #1767

What does this PR do?

  • TODO
  • TODO Revert some type separation
  • open another PR on which this will depend, about test for HttpRequests

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added the breaking-change The related changes are breaking for the users label Apr 18, 2025
@flevi29 flevi29 mentioned this pull request Apr 25, 2025
1 task
@flevi29 flevi29 mentioned this pull request Apr 25, 2025
3 tasks
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.29%. Comparing base (69e056c) to head (25b33cc).

Files with missing lines Patch % Lines
src/meilisearch.ts 81.81% 4 Missing ⚠️
src/utils.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1925      +/-   ##
==========================================
- Coverage   99.02%   95.29%   -3.73%     
==========================================
  Files          18       17       -1     
  Lines        1435     1446      +11     
  Branches      303      278      -25     
==========================================
- Hits         1421     1378      -43     
- Misses         14       68      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
1 participant