[WC-2481] Image: Enhance dimension properties #1827
Merged
+91
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
reviewed
Aug 12, 2025
gjulivan
force-pushed
the
feat/WC-2481_image-height-percentage
branch
from
8409871 to
6e94679
Compare
yordan-st
force-pushed
the
feat/WC-2481_image-height-percentage
branch
from
56bf22b to
06ee7cc
Compare
leonardomendix
approved these changes
Aug 25, 2025
gjulivan
force-pushed
the
feat/WC-2481_image-height-percentage
branch
from
06ee7cc to
b39cb3f
Compare
gjulivan
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
Added support to configure a
min-heightand ormax-heightfor the image when the height unit is set toautoAdded the viewport unit (
vh) while setting the height, min-height and max-height valuesWhat should be covered while testing?