Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow supported Fastify version to 5.x #26

Conversation

jonnydgreen
Copy link

Narrowing the supported Fastify version to 5.x to ensure the plugin works as expected in the supported versions defined in the README.

Once merged, we are all good to release I believe! :)

@jonnydgreen jonnydgreen requested a review from mcollina October 12, 2024 12:37
@jonnydgreen jonnydgreen self-assigned this Oct 12, 2024
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonnydgreen jonnydgreen merged commit 71481dc into mercurius-js:master Oct 14, 2024
6 checks passed
@jonnydgreen jonnydgreen deleted the chore/narrow-supported-fastify-version-to-v5 branch October 14, 2024 17:01
@jonnydgreen
Copy link
Author

@mcollina it seems that I don't have access to this package in npm! When you have a moment, are you able to release this instead? Or alternatively, able to grant me access for this? :) cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants