feat: APQ should persist queries only when inside an APQ flow #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit conflicted on the semversiness of this. What do you think? |
Good question! Based on the test here, I think this is technically a breaking change? https://github.com/mercurius-js/mercurius/pull/1124/files#diff-5c532c8a8a16879f154d85383fa4f7e9d816ac20e808665e21657277968479f7R398 So maybe a major version? wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1123
While updating tests I noticed that the behavior I'm "fixing" was explicitely tested, so presumably desired. I haven't found any references of this on Apollo Server APQ flow, but now I'm unsure if this should be considered a Breaking Change or not.