Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjust pie chart title to prevent cropping and added example for testing #6242

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

nourhenta
Copy link

@nourhenta nourhenta commented Jan 31, 2025

Description

Fixes #6232 - Pie Chart Title Gets Cut Off if Too Long

Solution

  • Dynamically adjusts the font size of the pie chart title to fit within the chart's width.
  • Updated the example.html to showcase the solution with a long title.

Testing

Tested with different title lengths to ensure proper resizing. Attached a screenshot of the result.

Notes

This solution avoids splitting the title into multiple lines and maintains the design aesthetics by scaling the font size.

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: c879a9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 31, 2025

👷 Deploy Preview for mermaid-js processing.

Name Link
🔨 Latest commit c879a9d
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67f57361487a08000767de4e

Copy link

pkg-pr-new bot commented Jan 31, 2025

Open in StackBlitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6242
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6242
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6242
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6242

commit: c879a9d

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 3.86%. Comparing base (ceb8d4c) to head (264ada6).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/pie/pieRenderer.ts 0.00% 26 Missing ⚠️
...ges/mermaid/src/diagrams/class/classRenderer-v2.ts 0.00% 25 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6242      +/-   ##
==========================================
- Coverage     3.86%   3.86%   -0.01%     
==========================================
  Files          411     412       +1     
  Lines        43178   43214      +36     
  Branches       664     664              
==========================================
  Hits          1670    1670              
- Misses       41508   41544      +36     
Flag Coverage Δ
unit 3.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/mermaid/src/diagrams/class/classRenderer-v2.ts 0.34% <0.00%> (-0.03%) ⬇️
packages/mermaid/src/diagrams/pie/pieRenderer.ts 0.67% <0.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nourhenta, thanks for the PR, love the dynamic sizing!
We need to make a few changes for it to be merged.

  • Please revert all the prettier related changes, these can be added in a separate PR
  • Remove changes from unrelated files like classRenderer

Although not a hard requirement, It would be good to split the title into lines, if it's overflowing, even after the min font size is reached.

Copy link

argos-ci bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Awaiting the start of a new Argos build…

@nourhenta nourhenta requested a review from sidharthv96 April 6, 2025 21:12
Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a rendering test that showcases titles with varying lengths.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was these changes supposed to be part of a different PR?
I'm not sure why we need class Renderer changes in a Pie diagram PR.

pnpm-lock.yaml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file from the PR?

@nourhenta nourhenta requested a review from sidharthv96 April 8, 2025 18:32
@nourhenta nourhenta force-pushed the fix-pie-chart-title-6232 branch from 264ada6 to c879a9d Compare April 8, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pie Chart Title gets cut off if too long
2 participants