-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Adjust pie chart title to prevent cropping and added example for testing #6242
base: develop
Are you sure you want to change the base?
Conversation
|
👷 Deploy Preview for mermaid-js processing.
|
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6242 +/- ##
==========================================
- Coverage 3.86% 3.86% -0.01%
==========================================
Files 411 412 +1
Lines 43178 43214 +36
Branches 664 664
==========================================
Hits 1670 1670
- Misses 41508 41544 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nourhenta, thanks for the PR, love the dynamic sizing!
We need to make a few changes for it to be merged.
- Please revert all the prettier related changes, these can be added in a separate PR
- Remove changes from unrelated files like classRenderer
Although not a hard requirement, It would be good to split the title into lines, if it's overflowing, even after the min font size is reached.
The latest updates on your projects. Learn more about Argos notifications ↗︎ Awaiting the start of a new Argos build… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a rendering test that showcases titles with varying lengths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was these changes supposed to be part of a different PR?
I'm not sure why we need class Renderer changes in a Pie diagram PR.
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file from the PR?
264ada6
to
c879a9d
Compare
Description
Fixes #6232 - Pie Chart Title Gets Cut Off if Too Long
Solution
Testing
Tested with different title lengths to ensure proper resizing. Attached a screenshot of the result.
Notes
This solution avoids splitting the title into multiple lines and maintains the design aesthetics by scaling the font size.