Add specific dependency handling for clang #13134
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
force-pushed
the
submit/clang-dep
branch
from
81506a3 to
ab5966d
Compare
tristan957
reviewed
Apr 23, 2024
docs/markdown/Dependencies.md
Outdated
Comment on lines
617
to
618
| Both libclang (the C interface) and the C++ interfaces are supported via the | ||
| `language` keyword. The default is to search for the `C++` interface. |
There was a problem hiding this comment.
I don't understand why we can't do this for Rust dependencies, @xclaesse.
|
/cc @thesamesam |
dcbaker
force-pushed
the
submit/clang-dep
branch
4 times, most recently
from
f65099e to
9a5107e
Compare
dcbaker
force-pushed
the
submit/clang-dep
branch
7 times, most recently
from
ed30059 to
287c36b
Compare
thesamesam
reviewed
Jul 12, 2024
thesamesam
reviewed
Jul 12, 2024
thesamesam
reviewed
Jul 12, 2024
dcbaker
force-pushed
the
submit/clang-dep
branch
from
287c36b to
25c9116
Compare
|
Now for the fun of getting the CI green. |
dcbaker
force-pushed
the
submit/clang-dep
branch
7 times, most recently
from
7c967db to
e2718dc
Compare
dcbaker
force-pushed
the
submit/clang-dep
branch
13 times, most recently
from
59050cc to
87afe53
Compare
dcbaker
force-pushed
the
submit/clang-dep
branch
2 times, most recently
from
f81683b to
834ef61
Compare
This check considers whether `-l{libname}` will find the lib correctly,
and that is true if library *must* be shared as well as if the library
should be shared, but can fall back to static.
…with modules I don't understand why these wouldn't be used for modules if they exist, and this breaks Clang, which only sets a global Clang_INCLUDE_DIRS, and doesn't provide per-module support.
Clang has two ways to be found, CMake, and by hand. Clang has some hurdles of use because of the way it's installed on many Linux distros, either in a separate prefix, in a prefix with LLVM, or in a common prefix, which requires some amount of effort to make it work.
dcbaker
force-pushed
the
submit/clang-dep
branch
from
834ef61 to
6d6a0e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang is fun. It has a C API library and C++ API libraries. It has the following configurations that need to be accounted for:
On top of that, to get the Clang Version for the C API you need to resort to some trickery. I've checked the implementation I came up with for clang 6-17 and it works for all of those. For the C++ API it's easy, because the header required is a C++ header.
TODO: