Add console keyword to run_command()
#14104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pture Line ending replace, to fix Windows CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #13968
Currently long-running programs using
run_commanddo not have any output until they have finished. This can give the indication that the configure step is (wrongfully) stuck. Having console output during a long-runningrun_commandalso aides in debugging.I used a pair of threads to monitor the process output pipes (stdout/stderr) where they optionally forward the output to real stdout/stderr and optionally save it for later. This way you can optionally capture the output (for later use) at the same time as it is being shown in console. 🙂
To test this I beefed up the
test cases/common/33 run program/meson.buildscript to output the four cases (captureon/off,consoleon/off).