Speedup extract_objects #14109
Open
Speedup extract_objects #14109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
The proj_dir_to_build_root argument of determine_ext_objs is always empty, remove it. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This is a very hot function, improve the memoization of the results by removing an argument (that is almost always empty, in fact). Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
bonzini
force-pushed
the
speedup-extobjs
branch
from
5978d05 to
9b0a319
Compare
|
TASKING added an expensive call to get_compiler_for_source() in _determine_ext_objs(), so I'm going to propose this for 1.7 as soon as CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building QEMU, about 10% of the time is spent in flatten_object_list due to its use of _determine_ext_objs and object_filename_from_source. With a little preparation, the results from both of these can be memoized.
This PR tackles _determine_ext_objs() and a particularly hot part of object_filename_from_source() (which is
canonicalize_filename()), both of which can be (mostly) handled just with functools.lru_cache.