compilers: allow combining address and leak sanitizers #14128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not currently allow combining the address and leak sanitizers with
one another. This mode is officially documented as supported by at least
LLVm though, as documented in [1]:
LeakSanitizer is a run-time memory leak detector. It can be combined
with AddressSanitizer to get both memory error and leak detection,
or used in a stand-alone mode.
Add the combination to the list of allowed sanitizers.
[1]: https://clang.llvm.org/docs/LeakSanitizer.html
Signed-off-by: Patrick Steinhardt <ps@pks.im>
pks-t
force-pushed
the
pks-sanitize-address-and-leak
branch
from
95d16eb to
6569e76
Compare
|
The main problem with this is that it isn't ambitious enough. :D See #12648 |
@eli-schwartz Ah, perfect! I was pondering whether to convert the option to an array as it doesn't feel like it is well-maintainable going forward. It feels like that PR is mostly stale by now? If so I may try to have a look at whether I am able to fix remaining issues with Cuda there. |
|
In any case, let me close this PR in favor of that other one. |
If you could figure out the test failures there, that would be fantastic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not currently allow combining the address and leak sanitizers with one another. This mode is officially documented as supported by at least LLVm though, as documented in 1:
Add the combination to the list of allowed sanitizers.