Fix tasking compiler after option refactor #14625
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The weird format is to minimize the diff in the next fixup patch.
Actually take an override into account, ie:
```meson
library(
...
override_options : {'b_lto' : false},
)
```
dcbaker
force-pushed
the
submit/fix-tasking-compiler
branch
from
c2090a9 to
14c01d2
Compare
|
@gerioldman: I think you're the person who knows the most (and can test) the tasking compiler? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two distinct changes here, both bug fixes, only one is a regression though.
b_ltowas overridden off it would still expect the name to be .ma not .a