-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add eld as default linker for Qualcomm Hexagon compiler #14632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
hi @dcbaker |
We can't change the linker ID, that's a part of the DSL, with It also doesn't look like eld is just a rename of their existing qlcd linker, but it's a completely different linker. So, we should have a new representation for that, instead of renaming the old one. Also, please, add the new representation in one patch, and use it in a second patch. There's some documentation changes for this too. |
thanks for the quick review |
This all looks good, thanks. There's a page called the reference table (can't remember what the .md name is) that has a table of linker id's, that needs to be updated. Also, a release snippet that support was added would be good. |
thanks |
ELD is Qualcomm's open-source embedded linker. https://github.com/qualcomm/eld Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
Thanks for making all of the changes! @thesamesam, any more comments, or are you happy to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! Please do merge.
Sone of these changes look like they're all the same logical unit of change, and should be squashed into a single logical commit. e.g. documentation changes should be one change. (It is not clear to me whether the first two commits are doing one thing -- adding support for detecting eld -- or two things -- adding support for eld and making meson switch the default linker to use.) |
Qualcomm opensourced their linker recently https://github.com/qualcomm/eld
This PR sets eld as the default linker for Qualcomm's Hexagon compiler.