sanity_checks: add global build options #2401
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some projects need non-default options to avoid build failures, and are also frequent dependencies of other projects. Rather than adding "foo:tests=false" to all projects that depend on foo, allow specifying the option globally. Since we might want to disable foo tests only when foo is built as a dependency, ignore any global options that configure the project currently under test. Consolidate existing options for libxml2. Also disable building glib tests; 2.86.0 introduced a build failure on clang-cl, our glib CI already disables tests, and glib has a lot of them. Also drop an unneeded glib:sysprof=disabled in pango.
bgilbert
force-pushed
the
global-build-options
branch
from
a3bf8b9 to
b21c516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects need non-default options to avoid build failures, and are also frequent dependencies of other projects. Rather than adding
foo:tests=falseto all projects that depend on foo, allow specifying the option globally. Since we might want to disable foo tests only when foo is built as a dependency, ignore any global options that configure the project currently under test.Consolidate existing options for libxml2. Also disable building glib tests; 2.86.0 introduced a build failure on clang-cl, our glib CI already disables tests, and glib has a lot of them.
Also drop an unneeded
glib:sysprof=disabledin pango.