Feature/v2/cloud deploy #51

jmikedupont2 · 2025-03-14T14:28:13Z

Porting of scripts into new version

Future thoughts

We can think about moving these scripts into a new repo that holds Eliza as submodule so we don't need to change the base repo.
Basically, a packaging of another repo.

more

trag-bot · 2025-03-14T14:29:21Z

call_update.sh

+    --profile solfunmeme_dev \
+    --region us-east-2 \
+    --document-name "UpdateEliza" \
+    --document-version "\$LATEST" \


Using $LATEST version in production scripts is risky as it may lead to unexpected behavior when document versions change. Should specify explicit version for consistency.

trag-bot · 2025-03-14T14:29:59Z

codebuild.sh

@@ -0,0 +1,8 @@
+
+aws codebuild start-build --region us-east-2 \


The script lacks AWS credentials validation or profile specification, which could lead to authentication failures in non-interactive environments or when multiple AWS profiles are present.

trag-bot · 2025-03-14T14:30:33Z

docker-entrypoint-none.sh

+#apt install -y strace
+
+export COREPACK_ENABLE_DOWNLOAD_PROMPT=0
+corepack enable && corepack install --global pnpm@9.8.0


Global package installation requires root privileges but script doesn't check for root access. This could fail silently or with unclear error messages in non-root environments.

trag-bot · 2025-03-14T14:30:35Z

docker-entrypoint-none.sh

+
+#strace -f -o /opt/agent/strace.log -s99999 node CMD ["pnpm", "start", "--characters=characters/eliza.character.json"]
+#pnpm start --characters=characters/tine-test.character.json
+pnpm start --characters=$(ls -1p characters/*.json |  paste -sd,)


Glob expansion without error handling for no matches. If no JSON files exist, this will pass the glob pattern literally to pnpm. Also, filenames with spaces will break the command.

trag-bot · 2025-03-14T14:30:55Z

docker-entrypoint-strace.sh

+# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874264
+set -x
+#if [ "${1#-}" != "${1}" ] || [ -z "$(command -v "${1}")" ] || { [ -f "${1}" ] && ! [ -x "${1}" ]; }; then
+strace -f -o /opt/agent/strace.log -s99999 node "$@"


The script always runs strace regardless of conditions due to commented if statement, which could impact performance and create unnecessary logs in production environment

trag-bot · 2025-03-14T14:31:31Z

docker-entrypoint-strace2.sh

+apt update
+apt install -y strace


Running apt commands without sudo might fail in non-root environments. Additionally, there's no check if the script runs on a Debian-based system, which could cause failures on other distributions.

trag-bot · 2025-03-14T14:32:26Z

doit.sh

@@ -0,0 +1,21 @@
+
+nvm use 23


Node.js version 23 doesn't exist yet. The latest LTS version is 20.x, and the latest current version is 21.x. Using a non-existent version will cause the script to fail.

trag-bot · 2025-03-14T14:32:51Z

get_secrets.sh

+
+# Fetch all variables with the prefix and name them the same as the variable minus agent name underscore
+for key in $(aws ssm describe-parameters --query 'Parameters[?starts_with(Name, `'"${AGENT_NAME}"'_`)].Name' --output text); do
+    value=$(aws ssm get-parameter --name "$key" | jq .Parameter.Value -r)


The AWS SSM get-parameter command doesn't include --with-decryption flag, which means encrypted parameters won't be automatically decrypted.

trag-bot · 2025-03-14T14:32:54Z

get_secrets.sh

+echo "" > "/var/run/agent/secrets/env" # blank the file
+
+# Fetch all variables with the prefix and name them the same as the variable minus agent name underscore
+for key in $(aws ssm describe-parameters --query 'Parameters[?starts_with(Name, `'"${AGENT_NAME}"'_`)].Name' --output text); do


The command output isn't properly handled for cases where AWS CLI fails. Script continues execution even if AWS commands fail, potentially creating incomplete env file.

trag-bot · 2025-03-14T14:33:30Z

push_twitter.sh

@@ -0,0 +1,6 @@
+
+export TWITTER_EMAIL TWITTER_PASSWORD TWITTER_USER


The export statement uses TWITTER_USER but the AWS SSM command uses TWITTER_USERNAME, causing a mismatch in variable names that will result in empty value being stored in SSM.

trag-bot · 2025-03-14T14:33:31Z

push_twitter.sh

+
+export TWITTER_EMAIL TWITTER_PASSWORD TWITTER_USER
+
+aws ssm put-parameter     --name "tine_agent_twitter_password"  --value "${TWITTER_PASSWORD}" --type String


The script doesn't use --overwrite flag, which means it will fail if parameters already exist in SSM. This could cause deployment issues in existing environments.

trag-bot · 2025-03-14T14:33:50Z

run_with_groq.sh

@@ -0,0 +1,28 @@
+
+#
+bash ./get_secrets.sh


Script execution lacks error handling and verification of get_secrets.sh existence. A failed secrets retrieval could lead to authentication issues in subsequent Docker operations.

trag-bot · 2025-03-14T14:33:53Z

run_with_groq.sh

+docker kill agent-docker.service || echo skip
+docker rm --force agent-docker.service || echo skip
+
+/usr/bin/bash -c 'docker login -u AWS -p $(aws ecr get-login-password --region us-east-2) 767503528736.dkr.ecr.us-east-2.amazonaws.com'


Exposing AWS credentials in command line is insecure. The password could be visible in process lists or system logs. Should use environment variables or AWS credentials file.

trag-bot · 2025-03-14T14:34:23Z

run_with_groq_docker.sh

+		--env-file /var/run/agent/secrets/env \
+		--rm \
+		--name "agent-docker.service" \
+		--entrypoint /opt/agent/docker-entrypoint-strace2.sh $DOCKERIMAGE


The script uses $DOCKERIMAGE variable in the final docker run command, but this variable is never defined. It should likely be $CORE_AGENT_IMAGE based on the context.

trag-bot · 2025-03-14T14:34:26Z

run_with_groq_docker.sh

@@ -0,0 +1,30 @@
+
+#
+bash ./get_secrets.sh


The script doesn't check if get_secrets.sh execution was successful. Failed secrets retrieval could lead to runtime issues in the container.

trag-bot · 2025-03-14T14:35:00Z

rundocker.sh

+if ! grep -q "^HOME" "/var/run/agent/secrets/env"; then
+    echo "WORKSPACE_DIR=\${STATE_DIRECTORY}" >> "/var/run/agent/secrets/env"
+fi


The condition checks for HOME but writes WORKSPACE_DIR, which appears to be a logic error. Also, the condition is identical to the previous if statement, suggesting a copy-paste error.

trag-bot · 2025-03-14T14:35:24Z

scripts/clean.sh

+cd "$(dirname "$0")"/..
+echo "Cleanup started."


The script doesn't check if the directory change was successful before proceeding. A failed cd command could lead to cleanup operations in the wrong directory.

trag-bot · 2025-03-14T14:36:08Z

set_secrets.sh

+#aws ssm put-parameter     --name "tine_agent_openai_key"  --value "${OPENAI_API_KEY}" --type String
+#aws ssm put-parameter     --name "tine_agent_openai_endpoint"  --value "${OPENAI_API_BASE}" --type String
+#aws ssm put-parameter     --name "tine_agent_openai_model"  --value "${LLMMODEL}" --type String
+aws ssm put-parameter     --name "tine_agent_groq_key"  --value "${GROQ_API_KEY}" --type String


Sensitive API key is stored without the --overwrite flag, which could lead to parameter creation failures if it already exists, and without SecureString type for encryption.

trag-bot · 2025-03-14T14:36:13Z

set_secrets.sh

+
+aws ssm put-parameter  --name "tine_agent_2_agent_image"  --value "h4ckermike/elizaos-eliza:feb10" --type String
+aws ssm put-parameter  --name "tine_agent_2_docker_username"  --value "${DOCKER_USERNAME}" --type String
+aws ssm put-parameter  --name "tine_agent_2_docker_password"  --value "${DOCKER_PASSWORD}" --type String


Docker credentials are stored as plain String type instead of SecureString, potentially exposing sensitive authentication data. Also missing --overwrite flag for consistency.

trag-bot · 2025-03-14T14:36:37Z

set_systemd.sh

@@ -0,0 +1,2 @@
+#!/bin/bash
+source /var/run/agent/secrets/env


The script doesn't check if the environment file exists before sourcing it. This could lead to silent failures and unpredictable behavior if the file is missing or inaccessible.

trag-bot · 2025-03-14T14:37:02Z

ssh-ssm.py

+    prms = {
+        "portNumber":["22"],
+        "localPortNumber":["2222"]
+    }


Hard-coded port numbers should be configurable parameters or environment variables to allow flexibility and security in different environments.

trag-bot · 2025-03-14T14:37:31Z

systemd/agent-docker-it.sh

+source /var/run/agent/secrets/env
+
+/usr/bin/docker run  -p 3000:3000  	\
+		-v tokenizer:/app/node_modules/@anush008/tokenizers/ \


Using the same volume name 'tokenizer' for two different mount points can cause conflicts and unexpected behavior. Each volume should have a unique name to ensure proper isolation.

trag-bot · 2025-03-14T14:38:23Z

systemd/agent-docker-local.sh

+#!/bin/bash
+
+source ./env
+/usr/bin/docker remove agent-docker.service


The command should be 'docker rm' instead of 'docker remove'. This is incorrect Docker CLI syntax and will fail. The command needs to be corrected to use the proper Docker command.

trag-bot · 2025-03-14T14:40:21Z

@trag-bot didn't find any issues in the code! ✅✨

trag-bot · 2025-03-14T14:41:06Z

Pull request summary

Updated Discord invitation link in the pull request template to the new server.
Added a GitHub Actions workflow to fetch news files daily at midnight UTC and allow manual triggering.
Introduced a new workflow to automatically update the changelog upon release publication.
Modified the Docker image creation workflow to include AWS credentials configuration and support for multiple platforms.
Created a new smoke test workflow to run on every push and pull request, ensuring integration tests are executed.
Refactored the integration tests workflow to use pnpm for package management and improved environment variable handling.
Added submodules for various Twitter-related plugins and clients to the project.
Updated dependencies in package.json and other configuration files to their latest versions.
Enhanced the Dockerfile to include additional setup steps and ensure the application starts correctly.
Implemented scripts for AWS SSM parameter management and Docker container management to streamline deployment processes.

mike dupont added 4 commits March 14, 2025 08:20

minimal patch

3fb18aa

more

update

a9e1661

update

6861c61

reset github actions

09062f5

trag-bot bot reviewed Mar 14, 2025

View reviewed changes

Update image.yaml

e7a4c1f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/v2/cloud deploy #51

Feature/v2/cloud deploy #51

jmikedupont2 commented Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot Mar 14, 2025

trag-bot bot commented Mar 14, 2025

trag-bot bot commented Mar 14, 2025

		@@ -0,0 +1,8 @@

		aws codebuild start-build --region us-east-2 \

		@@ -0,0 +1,6 @@

		export TWITTER_EMAIL TWITTER_PASSWORD TWITTER_USER


		export TWITTER_EMAIL TWITTER_PASSWORD TWITTER_USER

		aws ssm put-parameter --name "tine_agent_twitter_password" --value "${TWITTER_PASSWORD}" --type String

Feature/v2/cloud deploy #51

Are you sure you want to change the base?

Feature/v2/cloud deploy #51

Conversation

jmikedupont2 commented Mar 14, 2025

Future thoughts

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 14, 2025

Choose a reason for hiding this comment

trag-bot bot commented Mar 14, 2025

trag-bot bot commented Mar 14, 2025

Pull request summary