cloud deployment patch #54

jmikedupont2 · 2025-03-16T00:19:58Z

parent 777ee94
author mike dupont mike.dupont@introspector.local 1741968993 -0400 committer mike dupont mike.dupont@introspector.local 1742076983 -0400

revert

Create test.yaml

Update test.yaml

Update tauri-ci.yml

Update test.yaml

Update integrationTests.yaml

Update pr.yaml

bun start

bun

update scripts

update

Update image.yaml

adding docker

one phase commit

Relates to

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

fix: profile overflow issue

feat: better memory viewer

fix: cli agent command

mistakes were made

trag-bot · 2025-03-21T16:47:09Z

call_update.sh

+    --profile solfunmeme_dev \
+    --region us-east-2 \
+    --document-name "UpdateEliza" \
+    --document-version "\$LATEST" \


Using $LATEST version in production is risky as it may lead to unexpected behavior. Should specify explicit version number for better control and predictability.

trag-bot · 2025-03-21T16:47:52Z

codebuild.sh

@@ -0,0 +1,8 @@
+
+aws codebuild start-build --region us-east-2 \


Script doesn't verify AWS CLI installation or proper authentication before execution. Could fail silently or with unclear error messages.

trag-bot · 2025-03-21T16:48:28Z

docker-entrypoint-none.sh

+#pnpm start --characters=$(ls -1p characters/*.json |  paste -sd,)
+#fi
+#exec "$@"
+bun start # --characters=$(ls -1p characters/*.json |  paste -sd,)


The script assumes 'bun' is installed and available in the system path without checking its existence or providing a fallback mechanism, which could lead to runtime failures.

trag-bot · 2025-03-21T16:49:01Z

docker-entrypoint-strace.sh

+# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874264
+set -x
+#if [ "${1#-}" != "${1}" ] || [ -z "$(command -v "${1}")" ] || { [ -f "${1}" ] && ! [ -x "${1}" ]; }; then
+strace -f -o /opt/agent/strace.log -s99999 node "$@"


The script unconditionally runs strace without checking directory permissions or existence of /opt/agent. This could fail in environments where the directory doesn't exist or lacks write permissions.

trag-bot · 2025-03-21T16:49:25Z

docker-entrypoint-strace2.sh

+apt update
+apt install -y strace


Running apt commands without checking for root privileges can fail. Should include 'sudo' or verify script is running as root using 'if [ "$(id -u)" -ne 0 ]; then echo 'Must be root' >&2; exit 1; fi'

trag-bot · 2025-03-21T16:49:26Z

docker-entrypoint-strace2.sh

+
+
+#strace -f -o /opt/agent/strace.log -s99999 node CMD ["pnpm", "start", "--characters=characters/eliza.character.json"]
+strace -f -o /opt/agent/strace.log -s99999 bun start 


No verification that 'bun' is installed before attempting to use it. Should check if bun exists with 'command -v bun >/dev/null 2>&1 || { echo "bun not found"; exit 1; }'

trag-bot · 2025-03-21T16:50:16Z

doit.sh

@@ -0,0 +1,20 @@
+
+nvm use 23


Node.js version 23 doesn't exist yet. The latest LTS version is 20.x, and the latest current version is 21.x. Using a non-existent version will cause the script to fail.

trag-bot · 2025-03-21T16:50:18Z

doit.sh

+pnpm build
+popd
+
+pushd node_modules/.pnpm/better-sqlite3@11.8.1/node_modules/better-sqlite3/


Hardcoding package version in path makes script brittle. If better-sqlite3 version changes, script will fail. Should use dynamic path resolution or version variables.

trag-bot · 2025-03-21T16:50:43Z

get_secrets.sh

+
+# This script expects AGENT_NAME to be set to something like "tine_agent"
+
+mkdir -p "/var/run/agent/secrets/"


Directory creation lacks permission check and error handling. Script might fail silently if it lacks permissions to create directory in /var/run, which is typically restricted.

trag-bot · 2025-03-21T16:50:44Z

get_secrets.sh

+echo "" > "/var/run/agent/secrets/env" # blank the file
+
+# Fetch all variables with the prefix and name them the same as the variable minus agent name underscore
+for key in $(aws ssm describe-parameters --query 'Parameters[?starts_with(Name, `'"${AGENT_NAME}"'_`)].Name' --output text); do


AWS CLI command execution lacks error handling. If AWS credentials are invalid or network issues occur, the script will continue with empty parameters.

trag-bot · 2025-03-21T17:19:09Z

@trag-bot didn't find any issues in the code! ✅✨

trag-bot · 2025-03-21T17:19:39Z

Pull request summary

Added logging configuration options to the .env.example file for better control over log levels.
Introduced new API keys for GROQ and embedding models in the .env.example file to support additional functionalities.
Updated the GitHub Actions workflow for building and pushing Docker images to use a more recent version of the docker/build-push-action.
Modified the PR title check workflow to allow manual triggering via workflow_dispatch.
Changed the environment variable for TURBO_TEAM in multiple workflows to use secrets instead of variables for enhanced security.
Added a new workflow for building, pushing, and deploying to Phala Cloud, including environment variable configurations.
Created a new test workflow for building and pushing Docker images, ensuring consistent testing practices.
Updated the .gitignore file to include additional patterns for ignoring temporary and build files.
Added submodule configurations for various plugins in the .gitmodules file to manage dependencies more effectively.
Updated the README.md to include new environment settings and instructions for using the updated features.

jmikedupont2 force-pushed the feature/v2/docker branch 2 times, most recently from 3877f2e to 24df7b0 Compare March 16, 2025 19:21

tcm390 added 8 commits March 17, 2025 17:47

add agents side bar

f5fd7f7

group chat panel

0dcbc5b

add group panel

bbb452e

upload image

3cb03f8

update api for image uploading

ef9be56

world rooms api

cdc41dd

list rooms works

b986a37

group chat kind of work

a172dec

jmikedupont2 force-pushed the feature/v2/docker branch from 423a4ed to 38a9229 Compare March 17, 2025 12:17

tcm390 and others added 19 commits March 17, 2025 21:02

small ui fix

4e62660

user server id instead of room name

b9e7f5c

fix chat not passing issue

22c6a0d

vitest config

29c0f82

package json updates, test scripts

a52366e

plugin tests

6e1b4ba

types tests

3008d84

aws s3 tests

57fff02

Merge branch 'v2-develop' into chore/plugin-storage-s3-tests

52004b3

resolving conflicts

dbb373f

change docs to show v1.0.0-alpha default, fix showcase images

09bbf7f

update news

a5ac066

fix lastversion

44893a3

add CNAME file

01d2219

basic ui works

aee326a

fix avatar

933af03

small fix and move agentbar to group chat

0881a32

Merge branch 'v2-develop' into tcm/client-room3

f343acc

Merge branch 'v2-develop' into chore/plugin-storage-s3-tests

949e687

tcm390 and others added 14 commits March 20, 2025 23:31

margin

d006376

system prompts overflow

306fa37

system prompts overflow

7e4d5d2

Merge pull request elizaOS#4025 from elizaOS/tcm/ui-tweak

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

636a992

fix: profile overflow issue

fix url and start agent

be70361

wip: update memories viewer

c69592c

Update memory-viewer.tsx

9efd992

Update memory-viewer.tsx

11c3f34

correct deleteAgent

d4169d0

correct deleteAgent

9189cf9

Update agent-sidebar.tsx

e3f2850

Merge pull request elizaOS#4027 from elizaOS/v2-memories-viewer

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

e45c275

feat: better memory viewer

Merge branch 'v2-develop' into tcm/fix-cli-agent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

d4f31c1

Merge pull request elizaOS#4028 from elizaOS/tcm/fix-cli-agent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

0a566bd

fix: cli agent command

jmikedupont2 force-pushed the feature/v2/docker branch from 173bd5a to 02ab50a Compare March 21, 2025 00:16

removing the ip address

Loading
Loading status checks…

4aaa5b7

mistakes were made

jmikedupont2 force-pushed the feature/v2/docker branch from ee8eaa0 to 4aaa5b7 Compare March 21, 2025 16:45

trag-bot bot reviewed Mar 21, 2025

View reviewed changes

enable other plugins

Loading
Loading status checks…

1e818a7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cloud deployment patch #54

cloud deployment patch #54

jmikedupont2 commented Mar 16, 2025

trag-bot bot Mar 21, 2025

trag-bot bot Mar 21, 2025

trag-bot bot Mar 21, 2025

trag-bot bot Mar 21, 2025

trag-bot bot Mar 21, 2025

trag-bot bot Mar 21, 2025

trag-bot bot Mar 21, 2025

trag-bot bot Mar 21, 2025

trag-bot bot Mar 21, 2025

trag-bot bot Mar 21, 2025

trag-bot bot commented Mar 21, 2025

trag-bot bot commented Mar 21, 2025

		@@ -0,0 +1,8 @@

		aws codebuild start-build --region us-east-2 \



		#strace -f -o /opt/agent/strace.log -s99999 node CMD ["pnpm", "start", "--characters=characters/eliza.character.json"]
		strace -f -o /opt/agent/strace.log -s99999 bun start


		# This script expects AGENT_NAME to be set to something like "tine_agent"

		mkdir -p "/var/run/agent/secrets/"

cloud deployment patch #54

Are you sure you want to change the base?

cloud deployment patch #54

Conversation

jmikedupont2 commented Mar 16, 2025

Relates to

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot Mar 21, 2025

Choose a reason for hiding this comment

trag-bot bot commented Mar 21, 2025

trag-bot bot commented Mar 21, 2025

Pull request summary