daily build Docker/2025/03/24 #57
Conversation
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
packages/cli/src/commands/agent.ts
Outdated
| process.env.AGENT_RUNTIME_URL?.replace(/\/$/, '') || | ||
| `http://localhost:${process.env.SERVER_PORT}`; | ||
| const AGENTS_BASE_URL = `${AGENT_RUNTIME_URL}/api/agents`; | ||
| process.env.AGENT_RUNTIME_URL?.replace(/\/$/, '') || 'http://192.168.1.90:3000'; |
There was a problem hiding this comment.
This line is a statement without assignment, making it dead code. The result of the expression is not stored or used, and AGENT_RUNTIME_URL is undefined in the next line's usage.
packages/cli/src/commands/agent.ts
Outdated
| `http://localhost:${process.env.SERVER_PORT}`; | ||
| const AGENTS_BASE_URL = `${AGENT_RUNTIME_URL}/api/agents`; | ||
| process.env.AGENT_RUNTIME_URL?.replace(/\/$/, '') || 'http://192.168.1.90:3000'; | ||
| const AGENTS_BASE_URL = `${AGENT_RUNTIME_URL}/agents`; |
There was a problem hiding this comment.
AGENT_RUNTIME_URL is used but not defined. The previous line's result is not assigned to any variable, causing a runtime error when trying to use undefined AGENT_RUNTIME_URL.
packages/cli/src/commands/create.ts
Outdated
| @@ -323,7 +323,7 @@ export const create = new Command() | |||
| logger.info(`\nYour project is ready! Here's what you can do next: | |||
| 1. \`cd ${cdPath}\` to change into your project directory | |||
| 2. Run \`npx elizaos start\` to start your project | |||
| 3. Visit \`http://localhost:3000\` (or your custom port) to view your project in the browser`); | |||
| 3. Visit \`http://192.168.1.90:3000\` (or your custom port) to view your project in the browser`); | |||
There was a problem hiding this comment.
Hardcoding a specific IP address is problematic as it assumes network configuration and won't work across different environments. Should use localhost or dynamic IP detection.
packages/cli/src/commands/env.ts
Outdated
| @@ -173,7 +173,7 @@ async function listEnvVars(): Promise<void> { | |||
| logger.info('\n'); | |||
| logger.info( | |||
| colors.cyan( | |||
| 'You can also edit environment variables in the web UI: http://localhost:3000/settings' | |||
| 'You can also edit environment variables in the web UI: http://192.168.1.90:3000/settings' | |||
There was a problem hiding this comment.
Hardcoding specific IP addresses creates maintenance issues and reduces portability. The URL should be configurable through environment variables or configuration files to support different environments.
packages/cli/src/server/index.ts
Outdated
| @@ -43,7 +43,7 @@ export interface ServerOptions { | |||
| postgresUrl?: string; | |||
| } | |||
| const AGENT_RUNTIME_URL = | |||
| process.env.AGENT_RUNTIME_URL?.replace(/\/$/, '') || 'http://localhost:3000'; | |||
| process.env.AGENT_RUNTIME_URL?.replace(/\/$/, '') || 'http://192.168.1.90:3000'; | |||
There was a problem hiding this comment.
Hardcoding specific IP addresses in the codebase creates maintenance issues and reduces portability. This should be configurable through environment variables or configuration files.
jmikedupont2
force-pushed
the
docker/2025/03/24
branch
2 times, most recently
from
bc1a47d to
16afd46
Compare
| const result = await promptForProjectPlugins(mockProject); | ||
| // Add assertions based on expected behavior |
There was a problem hiding this comment.
Test case is incomplete without assertions. Missing verification of the function's behavior makes the test ineffective and potentially misleading for future developers.
| const result = await promptForProjectPlugins(singleAgentProject); | ||
| // Add assertions |
There was a problem hiding this comment.
Test case lacks assertions to verify the behavior with single agent format. Without assertions, the test provides no value in ensuring correct functionality.
| const result = await promptForProjectPlugins(emptyProject); | ||
| // Add assertions |
There was a problem hiding this comment.
Empty project test case has no assertions, making it impossible to verify if the function handles empty projects correctly. Test is essentially non-functional.
|
@trag-bot didn't find any issues in the code! ✅✨ |
Pull request summary
|
jmikedupont2
force-pushed
the
feature/v2/telegram
branch
from
73c1307 to
85350a1
Compare
Daily docker build