Skip to content

Don't rewrite a search prefix when attempting a suggestion #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oalders
Copy link
Member

@oalders oalders commented May 3, 2025

Fixes #1265

  • Add some aria roles to search form and search alert
  • Fix suggestion handling when there's a search prefix

Copy link

codecov bot commented May 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (ba434b7) to head (a0b2f4d).

Files with missing lines Patch % Lines
lib/MetaCPAN/Web/Controller/Search.pm 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3343      +/-   ##
==========================================
- Coverage   73.49%   73.44%   -0.06%     
==========================================
  Files          68       68              
  Lines        2388     2391       +3     
  Branches      335      336       +1     
==========================================
+ Hits         1755     1756       +1     
- Misses        507      508       +1     
- Partials      126      127       +1     
Files with missing lines Coverage Δ
lib/MetaCPAN/Web/Controller/Search.pm 78.43% <50.00%> (-2.82%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oalders oalders force-pushed the oalders/suggest branch 7 times, most recently from 572e600 to 36e95f9 Compare May 4, 2025 15:57
@oalders oalders force-pushed the oalders/suggest branch from 36e95f9 to a0b2f4d Compare May 4, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module name suggestion should preserve original search
1 participant