-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix split installs #2797
Closed
Closed
Fix split installs #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # play-services-base/core/src/main/java/org/microg/gms/common/PackageUtils.java
Co-authored-by: Marvin W <git@larma.de>
Verify that work accounts are only added by device owners or profile owners. For instance, Microsoft Intune will create a work profile (moving itself to the work profile in the process) before using the work account servce to create a work account, so at that point it will already be profile owner. Apps that are not the profile owner will subsequently not be able to disable the work account authenticator or remove the work account. The personal account would not have an owner and thus no application could enable the work account provider there.
Allows downloading large applications
* reduces temporary storage usage * speeds up installation by a little bit
Storage leaks can still happen if session commits have errors (for instance, because the device was shutdown during installation), as those sessions can still be reopened and retried according to docs. However, we may expect all dangling sessions to be cleared after a certain timespan in the magnitude of a day.
Auth files are now moved to `play-services-base-core` so they can be accessed by other the workaccount module.
Purchasing before downloading seems to be necessary in at least some cases for work profiles as well.
Support unexpected scenarios spotted in the wild on a best-effort basis: * Enterprise policies with apps missing policy fields * App not downloading due to not being purchased
…prevent multiple notifications from appearing when the download content is the same
# Conflicts: # build.gradle # play-services-base/core/src/main/kotlin/org/microg/gms/settings/SettingsProvider.kt # play-services-core/src/huawei/AndroidManifest.xml # play-services-core/src/main/res/values-ar/strings.xml # play-services-core/src/main/res/values-zh-rCN/strings.xml # vending-app/src/main/AndroidManifest.xml # vending-app/src/main/java/com/android/vending/licensing/LicenseChecker.kt # vending-app/src/main/java/org/microg/vending/billing/core/GooglePlayApi.kt # vending-app/src/main/java/org/microg/vending/billing/core/HttpClient.kt # vending-app/src/main/kotlin/com/android/vending/VendingRequestHeaders.kt # vending-app/src/main/kotlin/com/google/android/finsky/DeviceSyncInfo.kt # vending-app/src/main/kotlin/com/google/android/finsky/accounts/impl/AccountsChangedReceiver.kt # vending-app/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.