Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKS: make MN HTTP compileOnly and it moves token classes to security #1320

Merged
merged 41 commits into from
May 17, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented May 17, 2023

This PR moves several classes from the jwt module to security. This change will allow Micronaut Security to support other tokens (for example, Paseto tokens) apart from JWT tokens.

It also makes Micronaut HTTP a compile only dependency. It changes several APIs to take a generic instead of an HTTP Request.

@sdelamo sdelamo added the type: breaking Introduces a breaking change label May 17, 2023
@sdelamo sdelamo marked this pull request as ready for review May 17, 2023 09:13
@sdelamo sdelamo requested review from timyates and graemerocher May 17, 2023 09:13
@sdelamo sdelamo changed the title BREAKS: make HTTP optional move token classes to security BREAKS: make MN HTTP compileOnly and it moves token classes to security May 17, 2023
@sdelamo sdelamo merged commit 3964d00 into master May 17, 2023
@sdelamo sdelamo deleted the http-free branch May 17, 2023 14:14
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
1.2% 1.2% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Introduces a breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants