Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run "Update AL-Go System Files" on multiple branches #1037

Merged
merged 102 commits into from
Mar 3, 2025
Merged

Run "Update AL-Go System Files" on multiple branches #1037

merged 102 commits into from
Mar 3, 2025

Conversation

mazhelez
Copy link
Collaborator

@mazhelez mazhelez commented Apr 15, 2024 •
edited
Loading

Issue: When scheduling "Update AL-Go System Files" workflow, it runs only on the default branch (GitHub Actions limitation).

This PR alters the workflow to be able to schedule "Update AL-Go System Files" to run on multiple branches.
Manually dispatching the workflow also allows selecting the branches to run on (via a new input).

New property workflowSchedule setting, includeBranches, is added to specify the branches when running the workflow on a schedule.

mazhelez and others added 27 commits April 15, 2024 11:41
@mazhelez
Run "Update AL-Go System Files" on multiple branches
de2ddd1
@mazhelez
Run GetBranches on windows-latest by default
6daba1a
@mazhelez
Convert to JSON array
06589ab
@mazhelez
JSON stuff
b0b3020
@mazhelez
Always use array
fc39d35
@mazhelez
🤦‍♀️
5abda87
@mazhelez
🤦‍♀️
c8399f3
@mazhelez
🤦‍♀️
9b29103
@mazhelez
Add name property to GetBranches
25640df
@mazhelez
Convert arrays to JSON
e760d59
@mazhelez
Fix typo
c4ea9e0
@mazhelez
Default to main in AL-Go settings
f441952
@mazhelez
Use invoke-git
40eb235
@mazhelez
Fix README
57b08f8
@mazhelez
Minor fixes
e60b51e
@mazhelez
Import GitHub helper
b3ed51c
@mazhelez
Import GitHub module better
2c29e00
@mazhelez
Add logs
72a40df
@mazhelez
Debugging
bc88077
@mazhelez
Fix issue with types
7dab72d
@mazhelez
Fix param name
77e72f8
@mazhelez
Add -returnValue param to invoke-git
14be591
@mazhelez
Use matrix branch for CheckForUpdates
1b8dbc8
@mazhelez
Fix outputs
1198bad
@mazhelez
Add parenthesis
ba160a3
@mazhelez
Fix mistake when assigning output
1578131
@mazhelez
Merge branch 'main' into update-al-go-multiple-branches
b80bbec
freddydk
freddydk requested changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@freddydk freddydk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things - if you fix these, we can kick off end 2 end on this branch to see whether it has any side effects - I would not assume that.

freddydk and others added 2 commits February 28, 2025 09:37
@freddydk
Merge branch 'main' into update-al-go-multiple-branches
5f0c6b0
@mazhelez @aholstrup1
Apply suggestions from code review
e3ba454 
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
mazhelez
mazhelez commented Feb 28, 2025
View reviewed changes
freddydk
freddydk previously approved these changes Feb 28, 2025
View reviewed changes
@mazhelez mazhelez requested a review from freddydk February 28, 2025 13:38
@mazhelez mazhelez enabled auto-merge (squash) February 28, 2025 15:22
@mazhelez mazhelez merged commit aba9431 into microsoft:main Mar 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddydk freddydk freddydk approved these changes

@aholstrup1 aholstrup1 aholstrup1 approved these changes

@spetersenms spetersenms Awaiting requested review from spetersenms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mazhelez @freddydk @spetersenms @aholstrup1