-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(react-menu): integrate useSafeZoneArea() #34457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
layershifter
wants to merge
4
commits into
microsoft:master
Choose a base branch
from
layershifter:feat/menu-safe-zone-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(react-menu): integrate useSafeZoneArea() #34457
layershifter
wants to merge
4
commits into
microsoft:master
from
layershifter:feat/menu-safe-zone-integration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request demo site: URL |
f111bb1
to
cb2c6ca
Compare
📊 Bundle size reportUnchanged fixtures
|
24d7724
to
37f9431
Compare
@@ -0,0 +1,113 @@ | |||
import * as React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Menu Converged - split item 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Menu Converged - split item.default.submenu open.chromium.png | 777 | Changed |
vr-tests-react-components/Menu Converged - split item.default - RTL.submenu open.chromium.png | 775 | Changed |
vr-tests-react-components/Positioning 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Positioning.Positioning end.chromium.png | 725 | Changed |
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 309 | Changed |
vr-tests-react-components/Positioning (safe area) 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Positioning (safe area).using safe zone area.chromium.png | 0 | Added |
vr-tests-react-components/TagPicker 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1321 | Changed |
vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 678 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
7f85386
to
0c6b067
Compare
0c6b067
to
4ac3b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)