update dependencies #578
Merged
update dependencies #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the SQL server docker images from SQL 2017 to SQL 2022 to address dependency and CVE updates along with miscellaneous package updates.
- Updated the docker image and related parameters in the pipeline configuration.
- Modified the workflow docker run command to use the SQL 2022 image.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .pipelines/TestSql2017.yml | Updated display names, arguments, and RunName from SQL2017 to SQL2022. Consider if the file name should also be updated to reflect SQL 2022. |
| .github/workflows/pr-validation.yml | Updated docker run command to use SQL 2022 image. |
Files not reviewed (2)
- .vscode/settings.json: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
.pipelines/TestSql2017.yml:10
- [nitpick] The file name '.pipelines/TestSql2017.yml' is now misleading given that the pipeline runs a SQL 2022 image. Consider renaming the file to reflect the updated SQL version.
steps:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern SQL, modern Go, and misc updates for packages with CVEs.