Modernize type hints and clean up unused code #1928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernize type hints and clean up unused code
|
@microsoft-github-policy-service agree [company="{ShorthillsAI}"] |
Support Gemini models in addition to OpenAI and AzureOpenAI
|
@microsoft-github-policy-service agree company="ShorthillsAI" |
|
Hi! Thanks for your submission! I see your PR is doing two different things, one not necessarily aligned to the PR message. Thanks! |
| @@ -12,6 +12,11 @@ | |||
| create_openai_client, | |||
| create_openai_embeddings_llm, | |||
| ) | |||
| from fnllm.gemini import ( | |||
There was a problem hiding this comment.
Is this intended to be included in your PR?
Gemini support is not available in fnllm, this will just break
|
Cancelling the PR, Will raise after some required changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modernized type hints using Python 3.10+ syntax (e.g., list[str] instead of List[str]) and removed unused imports, variables, and functions to improve code clarity and maintainability.
Related Issues
[Reference any related issues or tasks that this pull request addresses.]
Proposed Changes
[List the specific changes made in this pull request.]
Checklist
Additional Notes
[Add any additional notes or context that may be helpful for the reviewer(s).]