skip null/undefined fields when serializing #1133

koros · 2024-04-03T17:01:46Z

Remove falsy evaluation to avoid situations where numbers like 0 or false are mistaken for null/undefined

packages/serialization/json/src/jsonSerializationWriter.ts

koros added 2 commits April 3, 2024 19:54

handle edge cases when determining which fields to skip

07b9f4e

Merge branch 'main' into feature/skip-null-fields-when-serializing

ab781a2

koros requested review from baywet, darrelmiller, zengin, ddyett, gavinbarron and andrueastman as code owners April 3, 2024 17:01

koros temporarily deployed to build_test April 3, 2024 17:01 — with GitHub Actions Inactive

andrueastman reviewed Apr 4, 2024

View reviewed changes

packages/serialization/json/src/jsonSerializationWriter.ts Outdated Show resolved Hide resolved

dont skip empty strings while serializing

b1abb95

koros temporarily deployed to build_test April 4, 2024 12:21 — with GitHub Actions Inactive

refactor skip logic

869b21a

koros had a problem deploying to build_test April 4, 2024 12:37 — with GitHub Actions Error

koros had a problem deploying to build_test April 4, 2024 12:37 — with GitHub Actions Failure

koros temporarily deployed to build_test April 4, 2024 12:41 — with GitHub Actions Inactive

koros temporarily deployed to build_test April 4, 2024 12:42 — with GitHub Actions Inactive

andrueastman previously approved these changes Apr 4, 2024

View reviewed changes

refactor Guid serialization logic

f1e120c

koros dismissed andrueastman’s stale review via f1e120c April 4, 2024 13:34

koros temporarily deployed to build_test April 4, 2024 13:34 — with GitHub Actions Inactive

use fetch function consistently to avoid bug while running on browser

3679fdb

koros temporarily deployed to build_test April 4, 2024 14:00 — with GitHub Actions Inactive

andrueastman approved these changes Apr 5, 2024

View reviewed changes

koros merged commit eed0a52 into main Apr 5, 2024
6 checks passed

koros deleted the feature/skip-null-fields-when-serializing branch April 5, 2024 08:32

koros mentioned this pull request Apr 5, 2024

Is it possible to skip undefined obj from json body? [Typescript] #1079

Closed

Provide feedback