Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed duration validation rules #1180

Merged
merged 2 commits into from
May 13, 2024
Merged

Fixed duration validation rules #1180

merged 2 commits into from
May 13, 2024

Conversation

X2Style
Copy link
Contributor

@X2Style X2Style commented May 10, 2024

Fixes #1169

@X2Style X2Style requested a review from a team as a code owner May 10, 2024 23:11
@X2Style X2Style mentioned this pull request May 10, 2024
Closed
baywet
baywet requested changes May 13, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions!
One comment + can you sign the CLA please? (see the bot comment)

@X2Style
Copy link
Contributor Author

X2Style commented May 13, 2024

@microsoft-github-policy-service agree

baywet
baywet approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet merged commit ffa3bda into microsoft:main May 13, 2024
6 checks passed
@baywet baywet mentioned this pull request May 13, 2024
Merged
@baywet
Copy link
Member

baywet commented May 13, 2024

publishing PR #1181

@X2Style X2Style deleted the fix/duration-validation branch May 29, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Parse duration
2 participants
@X2Style @baywet