Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds authorization handler #1575

Merged
merged 3 commits into from
Jan 31, 2025
Merged

feat: adds authorization handler #1575

merged 3 commits into from
Jan 31, 2025

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Jan 28, 2025

Resolves #1518

Add authorization handler middleware

@rkodev rkodev force-pushed the feat/authorization-handler branch from a9f16e5 to 4614ce1 Compare January 28, 2025 08:10
@rkodev rkodev force-pushed the feat/authorization-handler branch from 4614ce1 to 8ad84a9 Compare January 28, 2025 08:15
@rkodev rkodev marked this pull request as ready for review January 28, 2025 08:17
@rkodev rkodev requested a review from a team as a code owner January 28, 2025 08:17
baywet
baywet requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for getting this started!

@rkodev rkodev force-pushed the feat/authorization-handler branch from 8ad84a9 to 034829e Compare January 28, 2025 15:33
@rkodev rkodev force-pushed the feat/authorization-handler branch from 034829e to dcb369c Compare January 29, 2025 12:47
@rkodev rkodev force-pushed the feat/authorization-handler branch from dcb369c to 2af6c81 Compare January 30, 2025 00:16
baywet
baywet reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!
One remaining question on my side.

baywet
baywet approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge (squash) January 31, 2025 13:32
@baywet baywet merged commit f9ff6ab into main Jan 31, 2025
17 checks passed
@baywet baywet deleted the feat/authorization-handler branch January 31, 2025 13:35
@release-please release-please bot mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http - add authorization middleware support and factory overload
2 participants
@rkodev @baywet