-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/issue 1582 #1591
feature/issue 1582 #1591
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution here @tggoo
Could you look into the linting errors by running the linting command to fix it?
Line 51 in 7fb5cf8
"prettier:write": "npm run prettier:base -- --write \"packages/**/*.{ts,tsx}\"", |
Also, to help out with changelog generation, could you make sure the the PR has a commit that meets the guidelines at https://github.com/microsoft/kiota-typescript/blob/main/CONTRIBUTING.md#commit-message-format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
@tggoo a gentle reminder on this one. |
* feat: implement filename support in Content-Disposition header * test: add test cases for filename in Content-Disposition
00677c3
to
29c4d09
Compare
Apologies for the delay... I was caught up with work and studies. Thank you for your patience! I’ve now finished addressing your feedback and made the requested changes. Please take a look when you have time. Let me know if anything else needs to be improved! Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution here @tggoo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes!
Fixes #1582.
This feature implements support for including a filename when adding parts to a multipart body.