Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue 1582 #1591

Merged
merged 1 commit into from
Feb 17, 2025
Merged

feature/issue 1582 #1591

merged 1 commit into from
Feb 17, 2025

Conversation

tggoo
Copy link
Contributor

@tggoo tggoo commented Feb 8, 2025

Fixes #1582.

This feature implements support for including a filename when adding parts to a multipart body.

@tggoo tggoo requested a review from a team as a code owner February 8, 2025 18:08
@tggoo
Copy link
Contributor Author

tggoo commented Feb 9, 2025

@microsoft-github-policy-service agree

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution here @tggoo

Could you look into the linting errors by running the linting command to fix it?

"prettier:write": "npm run prettier:base -- --write \"packages/**/*.{ts,tsx}\"",

Also, to help out with changelog generation, could you make sure the the PR has a commit that meets the guidelines at https://github.com/microsoft/kiota-typescript/blob/main/CONTRIBUTING.md#commit-message-format

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@baywet
Copy link
Member

baywet commented Feb 13, 2025

@tggoo a gentle reminder on this one.
Let us know if you have any additional comments or questions.

* feat: implement filename support in Content-Disposition header
* test: add test cases for filename in Content-Disposition
@tggoo
Copy link
Contributor Author

tggoo commented Feb 15, 2025

@baywet
@andrueastman

Apologies for the delay... I was caught up with work and studies. Thank you for your patience!

I’ve now finished addressing your feedback and made the requested changes. Please take a look when you have time. Let me know if anything else needs to be improved!

Thanks again!

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution here @tggoo

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet merged commit 0a2edd2 into microsoft:main Feb 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support for filename in Content-Disposition header
3 participants