Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix! Removes singleton registries #1634

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

fix! Removes singleton registries #1634

wants to merge 21 commits into from
+620 −468

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Mar 10, 2025

Resolves #1244

baywet
baywet reviewed Mar 19, 2025
View reviewed changes
packages/serialization/form/src/browser/formParseNodeFactory.ts
* Creates an instance of JsonParseNode.
* @param backingStoreFactory - The factory to create backing stores.
*/
constructor(private readonly backingStoreFactory: BackingStoreFactory) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the parameter should be optional

baywet
baywet reviewed Mar 20, 2025
View reviewed changes
packages/serialization/json/src/browser/jsonParseNodeFactory.ts Outdated
* Creates an instance of JsonParseNode.
* @param backingStoreFactory - The factory to create backing stores.
*/
constructor(private readonly backingStoreFactory: BackingStoreFactory) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional parameter

packages/serialization/text/src/textParseNodeFactory.ts Outdated
* Creates an instance of TextParseNode.
* @param backingStoreFactory - The factory to create backing stores.
*/
constructor(private readonly backingStoreFactory?: BackingStoreFactory) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ask for the parameter if we're not doing anything with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: In Progress 🚧
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Singletons are not singletons in Typescript
2 participants
@rkodev @baywet