Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use compatible iterator types for the base types #1646

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

musale
Copy link
Contributor

@musale musale commented Mar 17, 2025

Closes #1645

@musale musale requested a review from a team as a code owner March 17, 2025 10:39
@musale musale requested review from andrueastman and rkodev and removed request for andrueastman and rkodev March 17, 2025 10:40
@musale musale merged commit 9608918 into main Mar 17, 2025
16 checks passed
@musale musale deleted the fix/abstractions-header-types branch March 17, 2025 12:53
@baywet
Copy link
Member

baywet commented Mar 18, 2025

@musale this is making the CI fail https://github.com/microsoft/kiota/actions/runs/13921315555/job/38955278703?pr=6297

Can you please have a look at that?

@musale
Copy link
Contributor Author

musale commented Mar 20, 2025

@musale this is making the CI fail microsoft/kiota/actions/runs/13921315555/job/38955278703?pr=6297

Can you please have a look at that?

I've reverted that change. I'm not sure why the fix worked locally yet the types aren't exported.

@baywet
Copy link
Member

baywet commented Mar 20, 2025

@musale it might only be a matter of the integration tests configuration, maybe the lib section in the ts config is not configured adequately?
It's be interesting to know where those types are defined to get a better understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

Mismatched types in Header methods cause errors
3 participants