Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json parser ArrayBuffer memory leak #1657

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Fix json parser ArrayBuffer memory leak #1657

merged 3 commits into from
Mar 19, 2025

Conversation

zZHorizonZz
Copy link
Contributor

This PR fixes ArrayBuffer memor leak as described in #1653

Closes #1653

@zZHorizonZz zZHorizonZz requested a review from a team as a code owner March 19, 2025 16:12
baywet
baywet previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

baywet
baywet reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you making the same change for the text deserializer please?

kiota-typescript/packages/serialization/text/src/textParseNode.ts

Line 23 in 3cd0e29

return inNodeEnv() ? Buffer.from(strValue, "base64").buffer : new TextEncoder().encode(strValue);

@zZHorizonZz
Copy link
Contributor Author

@microsoft-github-policy-service agree

baywet
baywet previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge March 19, 2025 18:00
@zZHorizonZz
Copy link
Contributor Author

These seem like formatting errors. I didn't really run format tasks as I did edits through GitHub's web vs code.

@baywet baywet disabled auto-merge March 19, 2025 19:17
@baywet baywet enabled auto-merge (squash) March 19, 2025 19:17
@baywet baywet merged commit 968a4fa into microsoft:main Mar 19, 2025
17 checks passed
@zZHorizonZz zZHorizonZz deleted the patch-1 branch March 19, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArrayBuffer possible memory leaking
2 participants
@zZHorizonZz @baywet