Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent error on undefined byte array value in serialization writers #1665

Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix: prevent error on undefined byte array value in serialization writers #1665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/serialization/json/src/jsonSerializationWriter.ts
View file
Original file line number Diff line number Diff line change
@@ -11,8 +11,9 @@ import { DateOnly, Duration, type Guid, isUntypedNode, type ModelSerializerFunct
export class JsonSerializationWriter implements SerializationWriter {
public writeByteArrayValue(key?: string, value?: ArrayBuffer | null): void {
if (!value) {
throw new Error("value cannot be undefined");
return;
}

const b64 = inNodeEnv() ? Buffer.from(value).toString("base64") : btoa(new TextDecoder().decode(value));
this.writeStringValue(key, b64);
}
4 changes: 2 additions & 2 deletions packages/serialization/text/src/textSerializationWriter.ts
View file
Original file line number Diff line number Diff line change
@@ -11,10 +11,10 @@ import { inNodeEnv, type DateOnly, type Duration, type Guid, type ModelSerialize
export class TextSerializationWriter implements SerializationWriter {
public writeByteArrayValue(key?: string, value?: ArrayBuffer | null): void {
if (!value) {
throw new Error("value cannot be undefined");
return;
}
const b64 = inNodeEnv() ? Buffer.from(value).toString("base64") : btoa(new TextDecoder().decode(value));

const b64 = inNodeEnv() ? Buffer.from(value).toString("base64") : btoa(new TextDecoder().decode(value));
this.writeStringValue(key, b64);
}
private static readonly noStructuredDataMessage = "text does not support structured data";
Loading