-
Notifications
You must be signed in to change notification settings - Fork 188
add azure linux-specific fips tests #3688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LiliDeng
merged 21 commits into
microsoft:main
from
tobiasb-ms:tobiasb-ms/updated-fips-tests
Apr 8, 2025
Merged
add azure linux-specific fips tests #3688
LiliDeng
merged 21 commits into
microsoft:main
from
tobiasb-ms:tobiasb-ms/updated-fips-tests
Apr 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Mar 4, 2025
squirrelsc
reviewed
Mar 4, 2025
squirrelsc
reviewed
Mar 4, 2025
squirrelsc
reviewed
Mar 4, 2025
squirrelsc
reviewed
Mar 19, 2025
squirrelsc
reviewed
Mar 19, 2025
squirrelsc
reviewed
Mar 19, 2025
squirrelsc
reviewed
Mar 19, 2025
squirrelsc
reviewed
Mar 19, 2025
squirrelsc
reviewed
Mar 19, 2025
squirrelsc
reviewed
Mar 19, 2025
squirrelsc
reviewed
Mar 20, 2025
squirrelsc
reviewed
Mar 20, 2025
squirrelsc
reviewed
Mar 20, 2025
tobiasb-ms
commented
Mar 20, 2025
squirrelsc
reviewed
Mar 21, 2025
squirrelsc
reviewed
Mar 21, 2025
squirrelsc
reviewed
Mar 21, 2025
squirrelsc
reviewed
Mar 21, 2025
tobiasb-ms
commented
Mar 24, 2025
squirrelsc
reviewed
Mar 26, 2025
@tobiasb-ms please continue to fix errors in the PR checks. |
|
squirrelsc
reviewed
Apr 7, 2025
LiliDeng
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Azure Linux-specific tests around FIPS compliance. Specifically, this change adds:
verify_fips_is_enabled_azl
: Verifies that an AZL system is in FIPS mode.verify_fips_is_disabled_azl
: Verifies that an AZL system is not in FIPS mode.verify_fips_enable_azl
: Verifies that an AZL system can be put into FIPS mode.verify_fips_disable_azl
: Verifies that an AZL system can be taken out of FIPS mode.It also removes the AZL code from
verify_fips_enable
.Due to the nature of these tests, they only make sense to run if we believe a machine is already in the correct mode. For example,
verify_fips_is_enabled_azl
would make sense on the marketplace imageMicrosoftCBLMariner:azure-linux-3:azure-linux-3-fips:latest
but not onMicrosoftCBLMariner:azure-linux-3:azure-linux-3:latest
.To accomplish this, we look at two things (see function
ensure_fips_expectations
).First, we see if a variable
testing_fips_image
was provided to the test case. If so, and if it isyes
orno
, we respect that.Second, we try to hit the azure metadata endpoint to get the image sku name. If that is a FIPS sku, we consider it to be a FIPS machine.
If neither exist, we skip the test.