Skip to content

Conversation

mattkur
Copy link
Contributor

@mattkur mattkur commented Aug 27, 2025

Add some marginal IO to the storvsp test. This pattern found a bug in in-development code, so I believe that this test change is generally useful.

@Copilot Copilot AI review requested due to automatic review settings August 27, 2025 22:45
@mattkur mattkur requested a review from a team as a code owner August 27, 2025 22:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the storvsp VMM test by adding I/O operations to exercise the storage virtual service provider functionality. The test now performs write operations to storage devices, which helps detect potential bugs during development.

  • Adds I/O operations using dd commands to write random data to storage devices
  • Generates 100MB of random data writes to both /dev/sda and /dev/sdb
  • Improves test coverage by exercising actual storage I/O paths

Copy link

… in-development code, so I believe that this test change is generally useful.
@mattkur mattkur force-pushed the add-io-to-vmm-storvsp-test branch from 0c67dbc to 17e33bc Compare August 30, 2025 13:01
Copy link

@jstarks
Copy link
Member

jstarks commented Aug 30, 2025

While you're here, can you also read back the data and ensure it matches what was written? You might need iflag=direct/oflag=direct to ensure that you're not just reading through the cache (does Linux cache direct block device accesses? I forget.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants