feat(trace-viewer): Improve spacing and layout in and between network details sections #35425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… details sections
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 flaky39017 passed, 805 skipped Merge workflow run. |
agg23
reviewed
Apr 2, 2025
| const keyLength = Object.keys(data).length; | ||
|
|
||
| return ( | ||
| <details className='network-details' open={isOpen} aria-label={title}> |
There was a problem hiding this comment.
The chevron is misaligned. It should be aligned with the close button in the top bar.
| event.preventDefault(); | ||
| setIsOpen(!isOpen); | ||
| }}> | ||
| {title} {!isOpen && showCountWhenCollapsed && `(${keyLength})`} |
There was a problem hiding this comment.
There should be more spacing between the title and the chevron.
| event.preventDefault(); | ||
| setIsOpen(!isOpen); | ||
| }}> | ||
| {title} {!isOpen && showCountWhenCollapsed && `(${keyLength})`} |
There was a problem hiding this comment.
I would just leave the count onscreen at all times.
|
|
||
| {requestBody && <div className='network-request-details-header'>Request Body</div>} | ||
| {requestBody && <CodeMirrorWrapper text={requestBody.text} mimeType={requestBody.mimeType} readOnly lineNumbers={true}/>} | ||
| <DetailsSection title='General' data={Object.entries({ |
| - 'row "param1: value2"' | ||
| - 'row "param2: value2"' | ||
| ` | ||
| ); | ||
|
|
||
| await page.getByText('endpoint').click(); |
There was a problem hiding this comment.
Please add at least one test dealing with expansion and collapse of the new DetailsSections.
| overflow: hidden; | ||
| margin-left: 10px; | ||
| } | ||
| .network-details { |
There was a problem hiding this comment.
Probably should scope this class name better, as it's more generic than we typically have.
| event.preventDefault(); | ||
| setIsOpen(!isOpen); | ||
| }}> | ||
| {title} {!isOpen && showCountWhenCollapsed && `(${keyLength})`} |
There was a problem hiding this comment.
Disable text selection on these headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #35214