fix(aria): toMatchAriaSnapshot with timeout: 0 should be able to generate baseline #35476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
reviewed
Apr 3, 2025
| @@ -100,6 +100,8 @@ export async function toMatchAriaSnapshot( | |||
| } else { | |||
| // When generating new baseline, run entire pipeline against impossible match. | |||
| expected = `- none "Generating new baseline"`; | |||
| if (timeout === 0) | |||
| timeout = 1; // one shot timeout | |||
There was a problem hiding this comment.
In Playwright timeout === 0 disables the timeout.
There was a problem hiding this comment.
that's exactly why we need a workaround for it.
|
Had some discussions with Dima. Adding this would be a big inconsistency with all our other expectations. The user can achieve the same behaviour themselves by setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35461. The user has a nifty workflow where they use
timeout: 0to stall the test while they're iterating on the website. This breaks if there's no baseline, because we compare to- none "Generating new baseline"infinitely. Adding a special case so that we take the first shot fixes it.This mirrors our behaviour for
toMatchSnapshot({ timeout: 0 })on missing baselines, where we take the first stable snapshot.