Implement OnScrollEndDrag Event Handler for ScrollView #14473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sharath2727 Can you fill out |
anupriya13
approved these changes
Apr 3, 2025
| @@ -248,6 +248,9 @@ export default class Bootstrap extends React.Component<{}, any> { | |||
| horizontal={this.state.horizontalValue} | |||
| onScrollBeginDrag={() => { | |||
| console.log('onScrollBeginDrag'); | |||
| }} | |||
| onScrollEndDrag={() => { | |||
There was a problem hiding this comment.
looks like some formatting issue, did you try "yarn format"?
There was a problem hiding this comment.
yarn lint:fix fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Enhancement (non-breaking change)
Why
Implement OnScrollEndDrag Event Handler for fabric implementation of ScrollView.
Resolves #13143
What
For reference: https://learn.microsoft.com/en-us/uwp/api/windows.ui.composition.interactions.interactiontracker?view=winrt-26100
Testing
Updated the ScrollViewSnapSample.tsx to include onScrollEndDrag event handler and verified the console prints onScrollEndDrag when interaction with scroller stops and lnertia state enters.
Optional: Used playground-composition.sln and metro server to test my changes.
Changelog
yes
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow