Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Add JsonConverter's to handle bool values when converting from PromptExecutionSettings #11336

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

.Net: Add JsonConverter's to handle bool values when converting from PromptExecutionSettings #11336

wants to merge 13 commits into from
+450 −4

Conversation

markwallace-microsoft
Copy link
Member

@markwallace-microsoft markwallace-microsoft commented Apr 2, 2025 •
edited
Loading

Motivation and Context

Closes #11304

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner April 2, 2025 12:20
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Apr 2, 2025
@github-actions github-actions bot changed the title Add a BoolJsonConverter to handle bool values when converting from PromptExecutionSettings .Net: Add a BoolJsonConverter to handle bool values when converting from PromptExecutionSettings Apr 2, 2025
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_11304 branch from 62533b1 to fabffc2 Compare April 2, 2025 14:29
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_11304 branch from 64b6d20 to 1251e9e Compare April 2, 2025 14:55
@markwallace-microsoft markwallace-microsoft changed the title .Net: Add a BoolJsonConverter to handle bool values when converting from PromptExecutionSettings .Net: Add JsonConverter's to handle bool values when converting from PromptExecutionSettings Apr 2, 2025
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_11304 branch from 1251e9e to 3b50fe7 Compare April 2, 2025 15:10
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_11304 branch from 3b50fe7 to 2838ce4 Compare April 2, 2025 15:13
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_11304 branch 2 times, most recently from 13b29e1 to 3b85499 Compare April 10, 2025 09:45
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_11304 branch from 3b85499 to 15a1fe9 Compare April 10, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerBarreto RogerBarreto RogerBarreto left review comments

@crickman crickman crickman left review comments

@dmytrostruk dmytrostruk dmytrostruk approved these changes

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: Bug: CreateFunctionFromPrompty does not deserialise boolean parameter values correctly
5 participants
@markwallace-microsoft @dmytrostruk @RogerBarreto @crickman @SergeyMenshykh