Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Add integration tests for no-vector models and fix bugs #11383

Merged
merged 6 commits into from
Apr 7, 2025
Merged

.Net: Add integration tests for no-vector models and fix bugs #11383

merged 6 commits into from
Apr 7, 2025

Conversation

westey-m
Copy link
Contributor

@westey-m westey-m commented Apr 4, 2025 •
edited
Loading

Motivation and Context

Some databases support crud operations without a vector.
#11274

Description

Add integration tests for no-vector models and fix bugs

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner April 4, 2025 15:53
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Apr 4, 2025
@github-actions github-actions bot changed the title Add integration tests for no-vector models and fix bugs .Net: Add integration tests for no-vector models and fix bugs Apr 4, 2025
roji
roji approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see some comments on file organization etc. Great to see the test coverage increasing!

roji
roji approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! See one question below (no need to change necessarily)

@westey-m westey-m merged commit b19fe4c into microsoft:feature-vector-data-preb2 Apr 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westey-m @roji @markwallace-microsoft