-
Notifications
You must be signed in to change notification settings - Fork 275
Remove BuildTimeUTC #5627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove BuildTimeUTC #5627
Conversation
@@ -1 +1,2 @@ | |||
#nullable enable | |||
*REMOVED*[TPEXP]Microsoft.Testing.Platform.Services.IPlatformInformation.BuildDate.get -> System.DateTimeOffset? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: While this is public API, it's experimental and I think we should be fine breaking it. I checked and currently it's used only by MSTest. It's not used by TUnit or xUnit.
@nohwnd Aside from the failures in CI caused by MissingMethodException for the removed API (because we use last MSTest from test-tools but we use MTP from the current build), are you generally okay with this change? |
Yes it is fine for me, I was not even aware of it being there, and there is no motivation in the original issue to include the time, so it was not a customer asking to do this. |
Context: the goal was to provide some kind of incentives for people to notice that their platform is old and they should probably be looking for a new version. |
I don't think I ever found it useful. It only adds burden IMO.