-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm] fix debug build #17078
[llvm] fix debug build #17078
Conversation
c83df1c
to
eb1dac2
Compare
@abique, could you report an issue for this? I'm unsure what failures that you encountered. |
@PhoebeHui the build failed because the include directory was empty. |
@@ -254,10 +254,12 @@ if(NOT DEFINED VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "debug") | |||
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include) | |||
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share) | |||
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/tools) | |||
|
|||
set(VCPKG_POLICY_EMPTY_INCLUDE_FOLDER enabled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows the debug build to complete with an empty include folder.
Hello @abique, could you tell which directory is empty? Could you provide also install command to reproduce your issue? vcpkg/ports/llvm/portfile.cmake Lines 199 to 203 in eb1dac2
vcpkg/ports/llvm/portfile.cmake Lines 209 to 213 in eb1dac2
|
Build in debug, see the portfile it is doing: |
@abique, Removing debug/include folder is by design in vcpkg, it will check the folder in post-build validation step. When you use the port, it will use the headers from include folder.
|
In my case I did build the debug with a custom toolchain/triplet with only debug. |
Could it be that it is a vcpkg error instead? |
Is it unsupported to install only the debug version of a port? |
@abique, only install debug or release version of a port may all have issues, or not, it depends what the port that was used. We hope this issue would be solved in future, however, currently we would suggest to solve this issue by using overlay or custom ports. |
I understand. |
LLVM did no build in debug because the include directory was removed.
I'm not sure this behavior is correct (llvm port). Yet I did add the policy so it builds.