[mpg123] Triplet VCPKG_BUILD_TYPE release fix #9056
Conversation
Fix builds which do not require debug files. Attempting to build mpg123 with VCPKG_BUILD_TYPE release set in a triplet will fail. This patch prevent builds from failing under VCPKG_BUILD_TYPE release build conditions.
|
/azp run |
ports/mpg123/portfile.cmake
Outdated
| @@ -48,36 +48,44 @@ if(VCPKG_TARGET_IS_WINDOWS) | |||
| vcpkg_build_msbuild( | |||
There was a problem hiding this comment.
If possible, I recommend trying to replace this with vcpkg_install_msbuild()[1].
[1] https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_install_msbuild.md
There was a problem hiding this comment.
Please feel free to act on your advice. I have no further interest in this port past just making it work and as such pushed this to just make it work under expected conditions. Previously, the port would fail. The upshot of this being that I just removed the requirement to use mp3 playback in the application I was building. Therefore no longer requiring the output of this port.
Thanks for the recommendation though and I'm sure that someone else is up to the challenge!
Edit: I will add that this port was patched at 56351a3 without following the guidance found at #6045.
Unfortunately, CMake's language doesn't support conditionals nested inside functions according to #9056 (comment) This patch aims to resolve an attempt to do so from the previous commit.
| # Debug build | ||
| ################ | ||
| message(STATUS "Configuring ${TARGET_TRIPLET}-dbg") | ||
| vcpkg_execute_required_process( |
There was a problem hiding this comment.
We already have a simple solution here: use vcpkg_configure_make[1] and vcpkg_install_make[2].
[1] https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_configure_make.md
[2] https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_install_make.md
There was a problem hiding this comment.
Proposed merge deleted and pull request closed.
Please update this port however you see fit. Or don't as the case may likely be.
Fix builds which do not require
debug files.
Attempting to build mpg123 with
VCPKG_BUILD_TYPE release set in
a triplet will fail. This patch
prevent builds from failing
under VCPKG_BUILD_TYPE release
build conditions.