Fix #242691: Tab bottom border briefly uses focus color on click #244764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lick This change checks if the user is performing a primary mouse click without any modifier keys. If the tab is already active, it prevents the default behavior of displaying the focus color in the bottom border. Signed-off-by: Carlos Teles <carlos.teles@tecnico.ulisboa.pt>
|
Looks like this might have been fixed just after this PR went out #244766 |
|
Closing as thee has been a fix in the mean time and because this fix might be breaking some interactions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change checks if the user is performing a primary mouse click without any modifier keys. If the tab is already active, it prevents the default behavior of displaying the focus color in the bottom border.
You can test it by running VS Code in dev mode and clicking on the tabs.
If you need more information, please ask!