Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing property initializiation order #245673

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Fixing property initializiation order #245673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build/lib/propertyInitOrderChecker.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion build/lib/propertyInitOrderChecker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const ignored = new Set([
'vs/editor/common/model/tokenizationTextModelPart.ts',
'vs/editor/common/core/textEdit.ts',
'vs/editor/browser/view/viewLayer.ts',
'vs/editor/browser/controller/editContext/textArea/textAreaEditContextInput.ts',
'vs/platform/accessibilitySignal/browser/accessibilitySignalService.ts',
'vs/editor/browser/widget/diffEditor/utils.ts',
'vs/editor/browser/observableCodeEditor.ts',
Expand Down
40 changes: 26 additions & 14 deletions src/vs/editor/browser/controller/editContext/textArea/textAreaEditContextInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,19 +619,19 @@ export class TextAreaInput extends Disposable {

export class TextAreaWrapper extends Disposable implements ICompleteTextAreaWrapper {

public readonly onKeyDown = this._register(new DomEmitter(this._actual, 'keydown')).event;
public readonly onKeyPress = this._register(new DomEmitter(this._actual, 'keypress')).event;
public readonly onKeyUp = this._register(new DomEmitter(this._actual, 'keyup')).event;
public readonly onCompositionStart = this._register(new DomEmitter(this._actual, 'compositionstart')).event;
public readonly onCompositionUpdate = this._register(new DomEmitter(this._actual, 'compositionupdate')).event;
public readonly onCompositionEnd = this._register(new DomEmitter(this._actual, 'compositionend')).event;
public readonly onBeforeInput = this._register(new DomEmitter(this._actual, 'beforeinput')).event;
public readonly onInput = <Event<InputEvent>>this._register(new DomEmitter(this._actual, 'input')).event;
public readonly onCut = this._register(new DomEmitter(this._actual, 'cut')).event;
public readonly onCopy = this._register(new DomEmitter(this._actual, 'copy')).event;
public readonly onPaste = this._register(new DomEmitter(this._actual, 'paste')).event;
public readonly onFocus = this._register(new DomEmitter(this._actual, 'focus')).event;
public readonly onBlur = this._register(new DomEmitter(this._actual, 'blur')).event;
public readonly onKeyDown: Event<KeyboardEvent>;
public readonly onKeyPress: Event<KeyboardEvent>;
public readonly onKeyUp: Event<KeyboardEvent>;
public readonly onCompositionStart: Event<CompositionEvent>;
public readonly onCompositionUpdate: Event<CompositionEvent>;
public readonly onCompositionEnd: Event<CompositionEvent>;
public readonly onBeforeInput: Event<InputEvent>;
public readonly onInput: Event<InputEvent>;
public readonly onCut: Event<ClipboardEvent>;
public readonly onCopy: Event<ClipboardEvent>;
public readonly onPaste: Event<ClipboardEvent>;
public readonly onFocus: Event<FocusEvent>;
public readonly onBlur: Event<FocusEvent>; // = this._register(new DomEmitter(this._actual, 'blur')).event;

public get ownerDocument(): Document {
return this._actual.ownerDocument;
Expand All @@ -647,12 +647,24 @@ export class TextAreaWrapper extends Disposable implements ICompleteTextAreaWrap
) {
super();
this._ignoreSelectionChangeTime = 0;
this.onKeyDown = this._register(new DomEmitter(this._actual, 'keydown')).event;
this.onKeyPress = this._register(new DomEmitter(this._actual, 'keypress')).event;
this.onKeyUp = this._register(new DomEmitter(this._actual, 'keyup')).event;
this.onCompositionStart = this._register(new DomEmitter(this._actual, 'compositionstart')).event;
this.onCompositionUpdate = this._register(new DomEmitter(this._actual, 'compositionupdate')).event;
this.onCompositionEnd = this._register(new DomEmitter(this._actual, 'compositionend')).event;
this.onBeforeInput = this._register(new DomEmitter(this._actual, 'beforeinput')).event;
this.onInput = <Event<InputEvent>>this._register(new DomEmitter(this._actual, 'input')).event;
this.onCut = this._register(new DomEmitter(this._actual, 'cut')).event;
this.onCopy = this._register(new DomEmitter(this._actual, 'copy')).event;
this.onPaste = this._register(new DomEmitter(this._actual, 'paste')).event;
this.onFocus = this._register(new DomEmitter(this._actual, 'focus')).event;
this.onBlur = this._register(new DomEmitter(this._actual, 'blur')).event;

this._register(this.onKeyDown(() => inputLatency.onKeyDown()));
this._register(this.onBeforeInput(() => inputLatency.onBeforeInput()));
this._register(this.onInput(() => inputLatency.onInput()));
this._register(this.onKeyUp(() => inputLatency.onKeyUp()));

this._register(dom.addDisposableListener(this._actual, TextAreaSyntethicEvents.Tap, () => this._onSyntheticTap.fire()));
}

Expand Down
Loading