Skip to content

Replace -v with -n and parameter expansion zsh shell integration #248663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Replace -v with -n and parameter expansion zsh shell integration #248663

wants to merge 1 commit into from

Conversation

anthonykim1
Copy link
Contributor

Resolves: #248463

@anthonykim1 anthonykim1 added this to the May 2025 milestone May 11, 2025
@anthonykim1 anthonykim1 requested a review from meganrogge May 11, 2025 22:13
@anthonykim1 anthonykim1 self-assigned this May 11, 2025
@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug terminal-shell-zsh An issue in the terminal specific to zsh, including shell integration labels May 11, 2025
@anthonykim1 anthonykim1 mentioned this pull request May 11, 2025
Open
meganrogge
meganrogge approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, but LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@anthonykim1 anthonykim1

Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-zsh An issue in the terminal specific to zsh, including shell integration
Projects
None yet
Milestone
May 2025
Development

Successfully merging this pull request may close these issues.

__vsc_update_env:7: unknown condition: -v
2 participants
@anthonykim1 @meganrogge