Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): フォローしているユーザーならフォロワー限定投稿のノートでもアンテナで検知できるように #15264

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

samunohito
Copy link
Member

@samunohito samunohito commented Jan 13, 2025

What

アンテナTLにおいて、フォローしているユーザのフォロワー限定投稿を検知できるようにします(ついでに自分あてのDMも)
Cherry-picked from yojo-art/cherrypick#568 team-shahu#38

Why

fix #14266

Additional info (optional)

  • ローカルで実際に動作確認
  • cherry-pickしたものの中にあるテストがpassすること

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 39.43%. Comparing base (6396243) to head (4ee63b7).

Files with missing lines Patch % Lines
packages/backend/src/core/AntennaService.ts 45.45% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15264      +/-   ##
===========================================
- Coverage    40.54%   39.43%   -1.11%     
===========================================
  Files         1568     1568              
  Lines       199142   199153      +11     
  Branches      3985     3656     -329     
===========================================
- Hits         80737    78541    -2196     
- Misses      117832   120001    +2169     
- Partials       573      611      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samunohito samunohito marked this pull request as ready for review January 13, 2025 06:22
@kakkokari-gtyih kakkokari-gtyih changed the title フォローしているユーザーならフォロワー限定投稿のノートでもアンテナで検知できるように enhance(backend): フォローしているユーザーならフォロワー限定投稿のノートでもアンテナで検知できるように Jan 14, 2025
Copy link
Contributor

@tai-cha tai-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これらの行は意図的に残しているものですか?

},
{
// https://github.com/misskey-dev/misskey/issues/9025
// https://github.com/yojo-art/cherrypick/pull/568
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ

Copy link
Member Author

@samunohito samunohito Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

それぞれ

・おそらく変更前の状態であった根拠を示すためのリンク
・fork側でテストを変えたことを明示するためのリンク

だと思われるので削除しました(どちらも役目を終えたと考える)

@@ -373,13 +373,26 @@ describe('アンテナ', () => {
},
{
// https://github.com/misskey-dev/misskey/issues/9025
label: 'ただし、フォロワー限定投稿とDM投稿を含まない。フォロワーであっても。',
// https://github.com/yojo-art/cherrypick/pull/568
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@samunohito
Copy link
Member Author

特に何も考えてなかったです
もともとあったmisskey-dev/misskeyのリンク含め要否を検討します

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

アンテナでフォローしているユーザーのフォロワー限定投稿を拾ってほしい
3 participants