-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(backend): フォローしているユーザーならフォロワー限定投稿のノートでもアンテナで検知できるように #15264
base: develop
Are you sure you want to change the base?
enhance(backend): フォローしているユーザーならフォロワー限定投稿のノートでもアンテナで検知できるように #15264
Conversation
Co-authored-by: kozakura913 <98575220+kozakura913@users.noreply.github.com> Co-authored-by: mai <74494945+chan-mai@users.noreply.github.com>
このPRによるapi.jsonの差分 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15264 +/- ##
===========================================
- Coverage 40.54% 39.43% -1.11%
===========================================
Files 1568 1568
Lines 199142 199153 +11
Branches 3985 3656 -329
===========================================
- Hits 80737 78541 -2196
- Misses 117832 120001 +2169
- Partials 573 611 +38 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これらの行は意図的に残しているものですか?
}, | ||
{ | ||
// https://github.com/misskey-dev/misskey/issues/9025 | ||
// https://github.com/yojo-art/cherrypick/pull/568 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
それぞれ
・おそらく変更前の状態であった根拠を示すためのリンク
・fork側でテストを変えたことを明示するためのリンク
だと思われるので削除しました(どちらも役目を終えたと考える)
@@ -373,13 +373,26 @@ describe('アンテナ', () => { | |||
}, | |||
{ | |||
// https://github.com/misskey-dev/misskey/issues/9025 | |||
label: 'ただし、フォロワー限定投稿とDM投稿を含まない。フォロワーであっても。', | |||
// https://github.com/yojo-art/cherrypick/pull/568 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
特に何も考えてなかったです |
What
アンテナTLにおいて、フォローしているユーザのフォロワー限定投稿を検知できるようにします(ついでに自分あてのDMも)
Cherry-picked from yojo-art/cherrypick#568 team-shahu#38
Why
fix #14266
Additional info (optional)
Checklist