Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] ノート作成後の後処理をワーカープロセスで実行するオプションを追加 #15273

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

samunohito
Copy link
Member

@samunohito samunohito commented Jan 13, 2025

What

NoteCreateService.postNoteCreated()をワーカープロセスで動かせるようになるオプションを追加します。
デフォルト値は今までと同じ動作(NoteCreateService.create()が呼ばれたプロセスと同じプロセスで呼ばれる)をします。

Why

fix #15052

Additional info (optional)

ローカルで実際に動作確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 70.45455% with 52 lines in your changes missing coverage. Please review.

Project coverage is 40.46%. Comparing base (6396243) to head (4eca4e0).

Files with missing lines Patch % Lines
...eue/processors/LocalUserDeliverProcessorService.ts 64.58% 17 Missing ⚠️
packages/backend/src/core/QueueService.ts 33.33% 12 Missing ⚠️
packages/backend/src/queue/types.ts 0.00% 9 Missing ⚠️
packages/backend/src/core/NoteCreateService.ts 86.27% 7 Missing ⚠️
...ackages/backend/src/queue/QueueProcessorService.ts 75.00% 5 Missing ⚠️
...ages/backend/src/server/web/ClientServerService.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15273      +/-   ##
===========================================
- Coverage    40.54%   40.46%   -0.09%     
===========================================
  Files         1568     1569       +1     
  Lines       199142   199308     +166     
  Branches      3985     3962      -23     
===========================================
- Hits         80737    80644      -93     
- Misses      117832   118090     +258     
- Partials       573      574       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samunohito samunohito changed the title [wip] NoteCreateService.postNoteCreated()をワーカープロセスで動かせるオプションの追加 [backend] ノート作成後の後処理をワーカープロセスで実行するオプションを追加 Jan 15, 2025
…ate-worker' into feat/15052-support-post-note-create-worker

# Conflicts:
#	CHANGELOG.md
@samunohito samunohito marked this pull request as ready for review January 15, 2025 23:46
@samunohito
Copy link
Member Author

open

@samunohito samunohito marked this pull request as draft January 16, 2025 00:00
@samunohito samunohito marked this pull request as ready for review January 16, 2025 00:04
@samunohito samunohito marked this pull request as draft January 16, 2025 01:17
@samunohito
Copy link
Member Author

思ったよりパワーが出ない可能性が出てきた

メインプロセスのみでHTTPリクエストを捌く状態では効果は見込めるものの、
複数ワーカープロセスで待ち受けたときはあまり変わらなくなってしまった

DBレプリケーション( #15109 )も取り入れて様子を見たいのでdraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

NoteCreateService.postNoteCreated()をワーカープロセスで動かせるオプションの追加
1 participant